Fix snmp-server host commad parsing (#1077)

* Fix snmp-server host commad parsing * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * remove extra spaces * removed extra spaces --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
ansible-collections · May 20, 2024 · 746df96 · 746df96
1 parent 46108d0
commit 746df96
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 4 deletions.
diff --git a/changelogs/fragments/snmp_parse_fix.yml b/changelogs/fragments/snmp_parse_fix.yml
@@ -0,0 +1,3 @@
+---
+bugfixes:
+  - snmp_server - Fix configuration command for snmp-server host.
diff --git a/plugins/module_utils/network/ios/rm_templates/snmp_server.py b/plugins/module_utils/network/ios/rm_templates/snmp_server.py
@@ -322,9 +322,9 @@ def __init__(self, lines=None, module=None):
                 ^snmp-server\shost
                 (\s(?P<host>\S+))?
                 (\s(?P<informs>informs))?
+                (\svrf\s(?P<vrf>\S+))?
                 (\sversion\s(?P<version>1|3|2c))?
                 (\s(?P<version_option>auth|noauth|priv))?
-                (\svrf\s(?P<vrf>\S+))?
                 (\s(?P<community_string>\S+))?
                 (\s+(?P<traps>.+$))?
                 """, re.VERBOSE,

diff --git a/tests/unit/modules/network/ios/test_ios_snmp_server.py b/tests/unit/modules/network/ios/test_ios_snmp_server.py
@@ -1681,9 +1681,10 @@ def test_ios_snmp_server_parsed(self):
     def test_ios_snmp_server_gathered(self):
         self.execute_show_command.return_value = dedent(
             """\
-            snmp-server host 172.16.2.99 checktrap  isis hsrp
-            snmp-server host 172.16.2.1 version 3 priv newtera  rsrb pim rsvp slb pki
-            snmp-server host 172.16.2.1 version 3 noauth replace-User!  slb pki
+            snmp-server host 172.16.2.99 checktrap isis hsrp
+            snmp-server host 172.16.2.1 version 3 priv newtera rsrb pim rsvp slb pki
+            snmp-server host 172.16.2.1 version 3 noauth replace-User! slb pki
+            snmp-server host 172.16.2.1 vrf vrf1 version 3 priv newtera1 rsrb pim
             """,
         )
         self.execute_show_command_user.return_value = dedent(
@@ -1753,6 +1754,14 @@ def test_ios_snmp_server_gathered(self):
                     "community_string": "checktrap",
                     "traps": ["isis", "hsrp"],
                 },
+                {
+                    "host": "172.16.2.99",
+                    "vrf": "vrf1",
+                    "version": "3",
+                    "version_option": "priv",
+                    "community_string": "newtera1",
+                    "traps": ["rsrb", "pim"],
+                },
             ],
             "users": [
                 {