Add support for FiftyGigabitEthernet (#1115)

* Add support for FiftyGigabitEthernet * add a changelog
ansible-collections · Sep 16, 2024 · c6597f7 · c6597f7
1 parent 89d11a7
commit c6597f7
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 2 deletions.
diff --git a/changelogs/fragments/fix_interface_fifty_interface.yml b/changelogs/fragments/fix_interface_fifty_interface.yml
@@ -0,0 +1,3 @@
+---
+bugfixes:
+  - ios_interfaces - Fixes rendering of FiftyGigabitEthernet as it was wrongly rendering FiftyGigabitEthernet as FiveGigabitEthernet.
diff --git a/plugins/module_utils/network/ios/ios.py b/plugins/module_utils/network/ios/ios.py
@@ -141,8 +141,10 @@ def _get_number(name):
         if_type = "FastEthernet"
     elif name.lower().startswith("fo"):
         if_type = "FortyGigabitEthernet"
-    elif name.lower().startswith("fi"):
+    elif name.lower().startswith("fiv"):
         if_type = "FiveGigabitEthernet"
+    elif name.lower().startswith("fif"):
+        if_type = "FiftyGigabitEthernet"
     elif name.lower().startswith("et"):
         if_type = "Ethernet"
     elif name.lower().startswith("vl"):

diff --git a/plugins/module_utils/network/ios/utils/utils.py b/plugins/module_utils/network/ios/utils/utils.py
@@ -286,8 +286,10 @@ def _get_number(name):
         if_type = "FastEthernet"
     elif name.lower().startswith("fo"):
         if_type = "FortyGigabitEthernet"
-    elif name.lower().startswith("fi"):
+    elif name.lower().startswith("fiv"):
         if_type = "FiveGigabitEthernet"
+    elif name.lower().startswith("fif"):
+        if_type = "FiftyGigabitEthernet"
     elif name.lower().startswith("long"):
         if_type = "LongReachEthernet"
     elif name.lower().startswith("et"):

diff --git a/tests/unit/modules/network/ios/test_ios_interfaces.py b/tests/unit/modules/network/ios/test_ios_interfaces.py
@@ -678,6 +678,10 @@ def test_ios_interfaces_rendered(self):
                         "name": "fiveGigabitEthernet",
                         "description": "Ansible UT FiveGigabitEthernet",
                     },
+                    {
+                        "name": "fiftyGigabitEthernet",
+                        "description": "Ansible UT for fiftyGigabitEthernet",
+                    },
                     {
                         "name": "ethernet1",
                         "description": "Ansible UT Ethernet",
@@ -750,6 +754,9 @@ def test_ios_interfaces_rendered(self):
             "interface FiveGigabitEthernet",
             "description Ansible UT FiveGigabitEthernet",
             "no shutdown",
+            "interface FiftyGigabitEthernet",
+            "description Ansible UT for fiftyGigabitEthernet",
+            "no shutdown",
             "interface Ethernet1",
             "description Ansible UT Ethernet",
             "no shutdown",