Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration test fix for ios_user and ios_facts #1034

Merged
merged 5 commits into from
Feb 16, 2024

Conversation

roverflow
Copy link
Member

@roverflow roverflow commented Feb 15, 2024

SUMMARY
  • Replaced the hash which was being used to test type 5 secret.
  • Changed loop logic for a task to include loop_control to fix error - The loop variable
    'item' is already in use.
ISSUE TYPE
  • Test fix

Copy link

codecov bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4154232) 86.79% compared to head (c49afa8) 86.79%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1034   +/-   ##
=======================================
  Coverage   86.79%   86.79%           
=======================================
  Files         197      197           
  Lines       12082    12082           
=======================================
  Hits        10487    10487           
  Misses       1595     1595           

@roverflow roverflow added the skip-changelog A trivial PR not requiring a change log for users label Feb 15, 2024
@roverflow roverflow changed the title Integration test fix for ios_user Integration test fix for ios_user and ios_facts Feb 15, 2024
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/8409aaacdadf435fbf068ad9009fded8

✔️ ansible-galaxy-importer SUCCESS in 5m 04s
✔️ build-ansible-collection SUCCESS in 9m 39s
ansible-ee-integration-ios-latest RETRY_LIMIT in 4m 06s (non-voting)
ansible-ee-integration-ios-stable-2.9 FAILURE in 12m 53s (non-voting)
ansible-ee-integration-ios-stable-2.11 RETRY_LIMIT in 7m 28s (non-voting)
ansible-ee-integration-ios-stable-2.12 RETRY_LIMIT in 5m 06s (non-voting)
ansible-ee-integration-ios-libssh-latest RETRY_LIMIT in 3m 59s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 16m 43s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.11 RETRY_LIMIT in 6m 06s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.12 RETRY_LIMIT in 7m 39s (non-voting)
✔️ ansible-tox-linters SUCCESS in 11m 31s

@KB-perByte KB-perByte merged commit 5a7f849 into ansible-collections:main Feb 16, 2024
55 checks passed
@roverflow roverflow deleted the fixintuser branch May 8, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog A trivial PR not requiring a change log for users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants