Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ios_acls] add fix to standalone remarks #1044

Merged
merged 8 commits into from
Mar 27, 2024

Conversation

KB-perByte
Copy link
Collaborator

@KB-perByte KB-perByte commented Mar 21, 2024

SUMMARY

The module now treats all the remarks for each ace as a block.

  1. every time a remark for an ace (with sequence) is updated the module would remove all the remarks for that ace entry by no <sequence> remark and add all the remarks back, as it is the only possible way to preserve the remarks order.
  2. Whenever an ace entry is updated it is removed first, which removes all the subordinate remarks. So we explicitly add the remarks back to maintain consistency and add back the ace entry.
  3. There is no line-by-line deletion of remarks entries, for every negation-specific action state remarks are removed as a whole and then added back.
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ios_acls

ADDITIONAL INFORMATION

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.91%. Comparing base (9bb7b30) to head (1022dcb).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1044      +/-   ##
==========================================
+ Coverage   86.87%   86.91%   +0.04%     
==========================================
  Files         197      197              
  Lines       12111    12116       +5     
==========================================
+ Hits        10521    10531      +10     
+ Misses       1590     1585       -5     

see 4 files with indirect coverage changes

Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/12e5b17deaa3464fb9c0f9735eec8e0f

✔️ ansible-galaxy-importer SUCCESS in 5m 16s
✔️ build-ansible-collection SUCCESS in 11m 53s
ansible-ee-integration-ios-latest RETRY_LIMIT in 4m 12s (non-voting)
ansible-ee-integration-ios-stable-2.9 FAILURE in 14m 45s (non-voting)
ansible-ee-integration-ios-stable-2.11 RETRY_LIMIT in 4m 12s (non-voting)
ansible-ee-integration-ios-stable-2.12 RETRY_LIMIT in 3m 23s (non-voting)
ansible-ee-integration-ios-libssh-latest RETRY_LIMIT in 3m 31s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 37m 18s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.11 RETRY_LIMIT in 4m 16s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.12 RETRY_LIMIT in 3m 38s (non-voting)
✔️ ansible-tox-linters SUCCESS in 12m 21s

Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/60744ea0bb0a4b48939020e3fe1175c0

✔️ ansible-galaxy-importer SUCCESS in 5m 05s
✔️ build-ansible-collection SUCCESS in 9m 56s
ansible-ee-integration-ios-latest RETRY_LIMIT in 4m 22s (non-voting)
ansible-ee-integration-ios-stable-2.9 FAILURE in 18m 07s (non-voting)
ansible-ee-integration-ios-stable-2.11 RETRY_LIMIT in 4m 08s (non-voting)
ansible-ee-integration-ios-stable-2.12 RETRY_LIMIT in 3m 34s (non-voting)
ansible-ee-integration-ios-libssh-latest RETRY_LIMIT in 3m 53s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 39m 45s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.11 RETRY_LIMIT in 3m 16s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.12 RETRY_LIMIT in 6m 08s (non-voting)
✔️ ansible-tox-linters SUCCESS in 12m 07s

Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/f227a47b01f34136bb74dcd00abb2a7a

✔️ ansible-galaxy-importer SUCCESS in 5m 17s
✔️ build-ansible-collection SUCCESS in 16m 47s
ansible-ee-integration-ios-latest RETRY_LIMIT in 3m 28s (non-voting)
ansible-ee-integration-ios-stable-2.9 FAILURE in 15m 30s (non-voting)
ansible-ee-integration-ios-stable-2.11 RETRY_LIMIT in 3m 18s (non-voting)
ansible-ee-integration-ios-stable-2.12 RETRY_LIMIT in 3m 25s (non-voting)
ansible-ee-integration-ios-libssh-latest RETRY_LIMIT in 3m 14s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 39m 12s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.11 RETRY_LIMIT in 3m 42s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.12 RETRY_LIMIT in 3m 28s (non-voting)
✔️ ansible-tox-linters SUCCESS in 22m 12s

@KB-perByte KB-perByte merged commit 71ecd84 into ansible-collections:main Mar 27, 2024
55 checks passed
@KB-perByte KB-perByte deleted the acls_single_remark branch March 27, 2024 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants