-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some idempotency issues in static_routes and bgp_global #1095
Conversation
@weippertt can you please add a changelog entry and a unit test case to test the changes added for bgp_global. |
I'm currently looking to understand the correct implementation of a unit test for bgp_global. One thing, is the fixture for bgp config currently in use?
Or am i completely wrong? |
for more information, see https://pre-commit.ci
I added something i thought it was ok ;) |
@KB-perByte does it look ok, or should i tweak some parts on the PR? |
SUMMARY
Found some minor issues on static_routes not idempotent when TenGigabitEthernet Interfaces in use and
within the same troubleshooting fixing also ebgp-multihop recognition
ISSUE TYPE
COMPONENT NAME
static_routes
bgp_global
ADDITIONAL INFORMATION
Add TenGigabitEthernet to interface regex to also recognize these type of interfaces in static routes.
Typo fixed and variable usage in bgp_global for ebgp-multihop