Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some idempotency issues in static_routes and bgp_global #1095

Merged
merged 5 commits into from
Jul 17, 2024

Conversation

weippertt
Copy link
Contributor

SUMMARY

Found some minor issues on static_routes not idempotent when TenGigabitEthernet Interfaces in use and
within the same troubleshooting fixing also ebgp-multihop recognition

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

static_routes
bgp_global

ADDITIONAL INFORMATION

Add TenGigabitEthernet to interface regex to also recognize these type of interfaces in static routes.
Typo fixed and variable usage in bgp_global for ebgp-multihop

@KB-perByte
Copy link
Collaborator

@weippertt can you please add a changelog entry and a unit test case to test the changes added for bgp_global.
Let us know if you need any help!
Regards!

@KB-perByte KB-perByte self-requested a review July 10, 2024 08:55
@weippertt
Copy link
Contributor Author

weippertt commented Jul 10, 2024

I'm currently looking to understand the correct implementation of a unit test for bgp_global.

One thing, is the fixture for bgp config currently in use?
I think no one is loading the fixture right now. So i think i need implement a test function ... something like

def test_ios_bgp_global_multihop(self): ...

Or am i completely wrong?
And is there an easy way to run the unit tests locally?

@weippertt
Copy link
Contributor Author

I'm currently looking to understand the correct implementation of a unit test for bgp_global.

One thing, is the fixture for bgp config currently in use? I think no one is loading the fixture right now. So i think i need implement a test function ... something like

def test_ios_bgp_global_multihop(self): ...

Or am i completely wrong? And is there an easy way to run the unit tests locally?

I added something i thought it was ok ;)

@weippertt
Copy link
Contributor Author

@KB-perByte does it look ok, or should i tweak some parts on the PR?

@KB-perByte KB-perByte merged commit bf5af1e into ansible-collections:main Jul 17, 2024
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants