Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ios_bgp_global/ address_family] fix parsing of password_options while gathering password configuratin #1122

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

KB-perByte
Copy link
Collaborator

SUMMARY
  • ios_bgp_global - fix parsing of password_options while gathering password configuration from appliance.
  • ios_bgp_address_family - fix parsing of password_options while gathering password configuration from appliance.
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ios_bgp_global
ios_bgp_address_family

ADDITIONAL INFORMATION
                    router bgp 65000
                     bgp nopeerup-delay post-boot 10
                     bgp bestpath compare-routerid
                     bgp advertise-best-external
                     timers bgp 100 200 150
                     redistribute connected metric 10
                     neighbor 192.0.2.1 remote-as 100
                     neighbor 192.0.2.1 password 7 DEQPITOP101395
                     neighbor 192.0.2.1 route-map test-route out
                     address-family ipv4
                      neighbor 192.0.2.28 activate
                      neighbor 172.31.35.140 activate

Parses -

{
            "as_number": "65000",
            "bgp": {
                "nopeerup_delay_options": {"post_boot": 10},
                "bestpath_options": {"compare_routerid": True},
                "default": {"ipv4_unicast": True, "route_target": {"filter": True}},
                "advertise_best_external": True,
            },
            "timers": {"keepalive": 100, "holdtime": 200, "min_holdtime": 150},
            "redistribute": [{"connected": {"set": True, "metric": 10}}],
            "neighbors": [
                {
                    "remote_as": "100",
                    "neighbor_address": "192.0.2.1",
                    "route_maps": [
                        {"name": "test-route", "out": True},
                    ],
                    "password_options": {
                        "encryption": 7,
                        "pass_key": "DEQPITOP101395",
                    },
                },
            ],
        }

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.06%. Comparing base (c9841b5) to head (526417a).
Report is 36 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1122      +/-   ##
==========================================
+ Coverage   86.90%   87.06%   +0.16%     
==========================================
  Files         193      199       +6     
  Lines       11904    12083     +179     
==========================================
+ Hits        10345    10520     +175     
- Misses       1559     1563       +4     

see 81 files with indirect coverage changes

@KB-perByte KB-perByte merged commit fa37d9e into ansible-collections:main Oct 16, 2024
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants