Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ios_line: Initiale commit to create the module ios_line #918

Open
wants to merge 26 commits into
base: main
Choose a base branch
from

Conversation

earendilfr
Copy link
Contributor

@earendilfr earendilfr commented Aug 27, 2023

This module has been tested on:

  • Cisco IOS-XE 17.06.05
  • Cisco IOS-XE 16.12.6
  • Cisco IOS 15.2(4)E10
SUMMARY

Add a new module ios_line to configure the lines part of Cisco IOS devices.
Currently, only line console and line vty are managed

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

ios_line

ADDITIONAL INFORMATION

The current module configure all the line console and vty.
It take in count the case that:

  • we cannot remove the line console 0
  • we cannot remove the line vty between 0 and 4

@codecov
Copy link

codecov bot commented Aug 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.03%. Comparing base (c9841b5) to head (04ff6b3).
Report is 9 commits behind head on main.

Current head 04ff6b3 differs from pull request most recent head fbc13c1

Please upload reports for the commit fbc13c1 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #918      +/-   ##
==========================================
+ Coverage   86.90%   87.03%   +0.13%     
==========================================
  Files         193      203      +10     
  Lines       11904    12384     +480     
==========================================
+ Hits        10345    10779     +434     
- Misses       1559     1605      +46     

see 53 files with indirect coverage changes

@earendilfr earendilfr changed the title ios_service: Initiale commit to create the module ios_service ios_line: Initiale commit to create the module ios_line Aug 27, 2023
@softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/328e828216714c58954748709e55d23e

✔️ ansible-galaxy-importer SUCCESS in 4m 46s
✔️ build-ansible-collection SUCCESS in 8m 41s
ansible-ee-integration-ios-latest FAILURE in 20m 09s (non-voting)
ansible-ee-integration-ios-stable-2.9 FAILURE in 20m 53s (non-voting)
ansible-ee-integration-ios-stable-2.11 FAILURE in 20m 32s (non-voting)
ansible-ee-integration-ios-stable-2.12 FAILURE in 20m 37s (non-voting)
ansible-ee-integration-ios-libssh-latest FAILURE in 20m 54s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 14m 07s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.11 FAILURE in 14m 33s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.12 FAILURE in 11m 58s (non-voting)
✔️ ansible-tox-linters SUCCESS in 10m 04s

@earendilfr earendilfr marked this pull request as ready for review August 28, 2023 15:28
@softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/30247fcbd3b64c1a95bfc80992cace28

✔️ ansible-galaxy-importer SUCCESS in 4m 34s
✔️ build-ansible-collection SUCCESS in 8m 41s
ansible-ee-integration-ios-latest FAILURE in 13m 17s (non-voting)
ansible-ee-integration-ios-stable-2.9 FAILURE in 15m 01s (non-voting)
ansible-ee-integration-ios-stable-2.11 FAILURE in 15m 03s (non-voting)
ansible-ee-integration-ios-stable-2.12 FAILURE in 14m 58s (non-voting)
ansible-ee-integration-ios-libssh-latest FAILURE in 14m 11s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 13m 55s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.11 FAILURE in 12m 45s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.12 FAILURE in 13m 05s (non-voting)
✔️ ansible-tox-linters SUCCESS in 10m 00s

@softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/a71c8bf49e084240bce5b237ddfdfa46

✔️ ansible-galaxy-importer SUCCESS in 6m 55s
✔️ build-ansible-collection SUCCESS in 8m 43s
ansible-ee-integration-ios-latest FAILURE in 24m 02s (non-voting)
ansible-ee-integration-ios-stable-2.9 FAILURE in 20m 54s (non-voting)
ansible-ee-integration-ios-stable-2.11 FAILURE in 23m 50s (non-voting)
ansible-ee-integration-ios-stable-2.12 FAILURE in 23m 34s (non-voting)
ansible-ee-integration-ios-libssh-latest FAILURE in 19m 32s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 19m 17s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.11 FAILURE in 21m 18s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.12 FAILURE in 21m 01s (non-voting)
✔️ ansible-tox-linters SUCCESS in 10m 17s

@softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/8d3cb409dd584e86be32ab8b176d4f5a

✔️ ansible-galaxy-importer SUCCESS in 5m 09s
✔️ build-ansible-collection SUCCESS in 9m 27s
ansible-ee-integration-ios-latest FAILURE in 13m 48s (non-voting)
ansible-ee-integration-ios-stable-2.9 FAILURE in 13m 52s (non-voting)
ansible-ee-integration-ios-stable-2.11 FAILURE in 12m 21s (non-voting)
ansible-ee-integration-ios-stable-2.12 FAILURE in 14m 51s (non-voting)
ansible-ee-integration-ios-libssh-latest FAILURE in 14m 45s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 12m 40s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.11 FAILURE in 14m 43s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.12 FAILURE in 12m 45s (non-voting)
✔️ ansible-tox-linters SUCCESS in 10m 12s

@KB-perByte KB-perByte temporarily deployed to ack October 31, 2023 16:41 — with GitHub Actions Inactive
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/457f8abaa9564ee79db353d3e99cc249

✔️ ansible-galaxy-importer SUCCESS in 5m 10s
✔️ build-ansible-collection SUCCESS in 11m 56s
ansible-ee-integration-ios-latest RETRY_LIMIT in 4m 09s (non-voting)
ansible-ee-integration-ios-stable-2.9 FAILURE in 28m 34s (non-voting)
ansible-ee-integration-ios-stable-2.11 RETRY_LIMIT in 4m 46s (non-voting)
ansible-ee-integration-ios-stable-2.12 RETRY_LIMIT in 4m 47s (non-voting)
ansible-ee-integration-ios-libssh-latest RETRY_LIMIT in 5m 29s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 25m 52s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.11 RETRY_LIMIT in 5m 02s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.12 RETRY_LIMIT in 3m 48s (non-voting)
✔️ ansible-tox-linters SUCCESS in 15m 57s

Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/8c2b17f03a534f4bad7475661239cd18

✔️ ansible-galaxy-importer SUCCESS in 3m 39s
✔️ build-ansible-collection SUCCESS in 10m 01s
ansible-ee-integration-ios-latest RETRY_LIMIT in 4m 52s (non-voting)
ansible-ee-integration-ios-stable-2.9 FAILURE in 18m 34s (non-voting)
ansible-ee-integration-ios-stable-2.11 RETRY_LIMIT in 4m 57s (non-voting)
ansible-ee-integration-ios-stable-2.12 RETRY_LIMIT in 4m 56s (non-voting)
ansible-ee-integration-ios-libssh-latest RETRY_LIMIT in 4m 59s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 18m 31s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.11 RETRY_LIMIT in 3m 33s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.12 RETRY_LIMIT in 4m 57s (non-voting)
✔️ ansible-tox-linters SUCCESS in 11m 50s

@KB-perByte
Copy link
Collaborator

Hey @earendilfr, we would be actively reviewing this PR and plan to merge it in future releases.
Please note we need some integration tests with the module contribution. Let us know if you need any help.
Thank you for your contribution.
Regards

Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/1c07169e8b374fdcb393b777b4fa2b03

✔️ ansible-galaxy-importer SUCCESS in 5m 04s
✔️ build-ansible-collection SUCCESS in 10m 17s
ansible-ee-integration-ios-latest RETRY_LIMIT in 6m 43s (non-voting)
ansible-ee-integration-ios-stable-2.9 FAILURE in 27m 19s (non-voting)
ansible-ee-integration-ios-stable-2.11 RETRY_LIMIT in 5m 26s (non-voting)
ansible-ee-integration-ios-stable-2.12 RETRY_LIMIT in 6m 57s (non-voting)
ansible-ee-integration-ios-libssh-latest RETRY_LIMIT in 6m 04s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 28m 27s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.11 RETRY_LIMIT in 5m 32s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.12 RETRY_LIMIT in 6m 23s (non-voting)
✔️ ansible-tox-linters SUCCESS in 11m 57s

@earendilfr
Copy link
Contributor Author

Hey @earendilfr, we would be actively reviewing this PR and plan to merge it in future releases. Please note we need some integration tests with the module contribution. Let us know if you need any help. Thank you for your contribution. Regards

Hey @KB-perByte, currently, it seems working fine from my point of view concerning this module.
Did you need other update concerning this PR ?

And I will also perform a PR on the repo https://github.com/ansible-network/resource_module_models top add this module too.

@KB-perByte KB-perByte self-requested a review November 28, 2023 15:15
@KB-perByte
Copy link
Collaborator

@earendilfr There needs to be some integration tests here, covering bare minimum functionality of the PR.
Could you please add some?
Regards

Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/fc0f3b1b97fc4e0f824617ea0f31d32b

✔️ ansible-galaxy-importer SUCCESS in 4m 05s
✔️ build-ansible-collection SUCCESS in 9m 43s
ansible-ee-integration-ios-latest RETRY_LIMIT in 3m 11s (non-voting)
ansible-ee-integration-ios-stable-2.9 FAILURE in 17m 14s (non-voting)
ansible-ee-integration-ios-stable-2.11 RETRY_LIMIT in 3m 14s (non-voting)
ansible-ee-integration-ios-stable-2.12 RETRY_LIMIT in 3m 26s (non-voting)
ansible-ee-integration-ios-libssh-latest RETRY_LIMIT in 3m 20s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 17m 12s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.11 RETRY_LIMIT in 3m 27s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.12 RETRY_LIMIT in 3m 17s (non-voting)
✔️ ansible-tox-linters SUCCESS in 11m 32s

Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/3448147beda04bf68714b87a0b5ba164

✔️ ansible-galaxy-importer SUCCESS in 4m 41s
✔️ build-ansible-collection SUCCESS in 10m 02s
ansible-ee-integration-ios-latest RETRY_LIMIT in 3m 50s (non-voting)
ansible-ee-integration-ios-stable-2.9 FAILURE in 14m 02s (non-voting)
ansible-ee-integration-ios-stable-2.11 RETRY_LIMIT in 3m 48s (non-voting)
ansible-ee-integration-ios-stable-2.12 RETRY_LIMIT in 4m 05s (non-voting)
ansible-ee-integration-ios-libssh-latest RETRY_LIMIT in 3m 18s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 14m 15s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.11 RETRY_LIMIT in 4m 03s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.12 RETRY_LIMIT in 3m 28s (non-voting)
✔️ ansible-tox-linters SUCCESS in 11m 43s

@earendilfr
Copy link
Contributor Author

@earendilfr There needs to be some integration tests here, covering bare minimum functionality of the PR. Could you please add some? Regards

OK: I have added some integration tests.
One question: did you have a command to validate the integration tests I have wrote?

Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/843828de7cf64ab4bb2d01e9a4d83822

✔️ ansible-galaxy-importer SUCCESS in 4m 56s
✔️ build-ansible-collection SUCCESS in 10m 31s
ansible-ee-integration-ios-latest RETRY_LIMIT in 3m 23s (non-voting)
ansible-ee-integration-ios-stable-2.9 FAILURE in 16m 37s (non-voting)
ansible-ee-integration-ios-stable-2.11 RETRY_LIMIT in 3m 28s (non-voting)
ansible-ee-integration-ios-stable-2.12 RETRY_LIMIT in 4m 14s (non-voting)
ansible-ee-integration-ios-libssh-latest RETRY_LIMIT in 3m 12s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 14m 24s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.11 RETRY_LIMIT in 3m 35s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.12 RETRY_LIMIT in 4m 57s (non-voting)
✔️ ansible-tox-linters SUCCESS in 11m 59s

Copy link

github-actions bot commented Dec 7, 2023

Label error. Requires exactly 1 of: bug, enhancement, major, minor, patch, skip-changelog. Found:

Allow to take in count the case where the ACL should be put for the VRF
- Fixe the config module to:
 - doesn't modify lines not indicated with the deleted and replaced
   profiles
 - take correctly in case the case where we have aux line present on
   device
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/636b9961300745698d0321ce4cad4c94

✔️ ansible-galaxy-importer SUCCESS in 4m 19s
✔️ build-ansible-collection SUCCESS in 9m 50s
ansible-ee-integration-ios-latest RETRY_LIMIT in 3m 19s (non-voting)
ansible-ee-integration-ios-stable-2.9 FAILURE in 16m 45s (non-voting)
ansible-ee-integration-ios-stable-2.11 RETRY_LIMIT in 3m 50s (non-voting)
ansible-ee-integration-ios-stable-2.12 RETRY_LIMIT in 3m 11s (non-voting)
ansible-ee-integration-ios-libssh-latest RETRY_LIMIT in 3m 26s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 16m 42s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.11 RETRY_LIMIT in 3m 31s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.12 RETRY_LIMIT in 3m 33s (non-voting)
✔️ ansible-tox-linters SUCCESS in 11m 27s

Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/795a351ce9f14793ad7e17485ef1a011

✔️ ansible-galaxy-importer SUCCESS in 4m 54s
✔️ build-ansible-collection SUCCESS in 10m 05s
ansible-ee-integration-ios-latest RETRY_LIMIT in 3m 22s (non-voting)
ansible-ee-integration-ios-stable-2.9 FAILURE in 17m 32s (non-voting)
ansible-ee-integration-ios-stable-2.11 RETRY_LIMIT in 3m 02s (non-voting)
ansible-ee-integration-ios-stable-2.12 RETRY_LIMIT in 3m 07s (non-voting)
ansible-ee-integration-ios-libssh-latest RETRY_LIMIT in 4m 17s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 14m 15s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.11 RETRY_LIMIT in 4m 17s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.12 RETRY_LIMIT in 4m 13s (non-voting)
✔️ ansible-tox-linters SUCCESS in 11m 44s

earendilfr and others added 11 commits February 2, 2024 11:42
This module has been tested on:
- Cisco IOS-XE 17.06.05
Need to force to resend the command `terminal length 0` in this case
Allow to take in count the case where the ACL should be put for the VRF
- Fixe the config module to:
 - doesn't modify lines not indicated with the deleted and replaced
   profiles
 - take correctly in case the case where we have aux line present on
   device
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/f9513754dae1475c83fdac288b969989

✔️ ansible-galaxy-importer SUCCESS in 4m 54s
✔️ build-ansible-collection SUCCESS in 9m 39s
ansible-ee-integration-ios-latest RETRY_LIMIT in 3m 59s (non-voting)
ansible-ee-integration-ios-stable-2.9 FAILURE in 11m 55s (non-voting)
ansible-ee-integration-ios-stable-2.11 RETRY_LIMIT in 3m 17s (non-voting)
ansible-ee-integration-ios-stable-2.12 RETRY_LIMIT in 3m 03s (non-voting)
ansible-ee-integration-ios-libssh-latest RETRY_LIMIT in 3m 06s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 12m 21s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.11 RETRY_LIMIT in 3m 56s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.12 RETRY_LIMIT in 3m 54s (non-voting)
✔️ ansible-tox-linters SUCCESS in 11m 38s

Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/e73ade9072a6427e8e5b87cdcc546df6

✔️ ansible-galaxy-importer SUCCESS in 5m 44s
✔️ build-ansible-collection SUCCESS in 9m 52s
ansible-ee-integration-ios-latest RETRY_LIMIT in 5m 00s (non-voting)
ansible-ee-integration-ios-stable-2.9 FAILURE in 15m 18s (non-voting)
ansible-ee-integration-ios-stable-2.11 RETRY_LIMIT in 5m 00s (non-voting)
ansible-ee-integration-ios-stable-2.12 NODE_FAILURE Node request 200-0007077968 failed in 0s (non-voting)
ansible-ee-integration-ios-libssh-latest NODE_FAILURE Node request 200-0007077971 failed in 0s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 14m 24s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.11 RETRY_LIMIT in 5m 17s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.12 RETRY_LIMIT in 5m 14s (non-voting)
✔️ ansible-tox-linters SUCCESS in 13m 50s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants