Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to the Config aggregator module #1830

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

rmahroua
Copy link
Contributor

@rmahroua rmahroua commented May 30, 2023

SUMMARY

The current aws_config_aggregator module has both account_sources and organization_source parameters listed as required.
However, the Config service API doesn't have any of these two parameters as required. This is because we can either configure an aggregator against a list of accounts or against all accounts in an organization.
This fix allows us to chose which parameters to pass instead of having to pass both.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

aws_config_aggregator

@github-actions
Copy link

github-actions bot commented May 30, 2023

Docs Build 📝

Thank you for contribution!✨

The docsite for this PR is available for download as an artifact from this run:
https://github.com/ansible-collections/community.aws/actions/runs/5432755073

You can compare to the docs for the main branch here:
https://ansible-collections.github.io/community.aws/branch/main

File changes:

  • M collections/community/aws/config_aggregator_module.html
Click to see the diff comparison.

NOTE: only file modifications are shown here. New and deleted files are excluded.
See the file list and check the published docs to see those files.

diff --git a/home/runner/work/community.aws/community.aws/docsbuild/base/collections/community/aws/config_aggregator_module.html b/home/runner/work/community.aws/community.aws/docsbuild/head/collections/community/aws/config_aggregator_module.html
index 6542619..2f20205 100644
--- a/home/runner/work/community.aws/community.aws/docsbuild/base/collections/community/aws/config_aggregator_module.html
+++ b/home/runner/work/community.aws/community.aws/docsbuild/head/collections/community/aws/config_aggregator_module.html
@@ -195,7 +195,7 @@ see <a class="reference internal" href="#ansible-collections-community-aws-confi
 </tr>
 <tr class="row-odd"><td><div class="ansible-option-cell">
 <div class="ansibleOptionAnchor" id="parameter-account_sources"></div><p class="ansible-option-title" id="ansible-collections-community-aws-config-aggregator-module-parameter-account-sources"><strong>account_sources</strong></p>
-<a class="ansibleOptionLink" href="#parameter-account_sources" title="Permalink to this option"></a><p class="ansible-option-type-line"><span class="ansible-option-type">list</span> / <span class="ansible-option-elements">elements=dictionary</span> / <span class="ansible-option-required">required</span></p>
+<a class="ansibleOptionLink" href="#parameter-account_sources" title="Permalink to this option"></a><p class="ansible-option-type-line"><span class="ansible-option-type">list</span> / <span class="ansible-option-elements">elements=dictionary</span></p>
 </div></td>
 <td><div class="ansible-option-cell"><p>Provides a list of source accounts and regions to be aggregated.</p>
 </div></td>
@@ -278,7 +278,7 @@ see <a class="reference internal" href="#ansible-collections-community-aws-confi
 </tr>
 <tr class="row-even"><td><div class="ansible-option-cell">
 <div class="ansibleOptionAnchor" id="parameter-organization_source"></div><p class="ansible-option-title" id="ansible-collections-community-aws-config-aggregator-module-parameter-organization-source"><strong>organization_source</strong></p>
-<a class="ansibleOptionLink" href="#parameter-organization_source" title="Permalink to this option"></a><p class="ansible-option-type-line"><span class="ansible-option-type">dictionary</span> / <span class="ansible-option-required">required</span></p>
+<a class="ansibleOptionLink" href="#parameter-organization_source" title="Permalink to this option"></a><p class="ansible-option-type-line"><span class="ansible-option-type">dictionary</span></p>
 </div></td>
 <td><div class="ansible-option-cell"><p>The region authorized to collect aggregated data.</p>
 </div></td>
@@ -416,11 +416,18 @@ see <a class="reference internal" href="#ansible-collections-community-aws-confi
 <span class="w">    </span><span class="nt">name</span><span class="p">:</span><span class="w"> </span><span class="l l-Scalar l-Scalar-Plain">test_config_rule</span>
 <span class="w">    </span><span class="nt">state</span><span class="p">:</span><span class="w"> </span><span class="l l-Scalar l-Scalar-Plain">present</span>
 <span class="w">    </span><span class="nt">account_sources</span><span class="p">:</span>
-<span class="w">      </span><span class="nt">account_ids</span><span class="p">:</span>
-<span class="w">      </span><span class="p p-Indicator">-</span><span class="w"> </span><span class="l l-Scalar l-Scalar-Plain">1234567890</span>
-<span class="w">      </span><span class="p p-Indicator">-</span><span class="w"> </span><span class="l l-Scalar l-Scalar-Plain">0123456789</span>
-<span class="w">      </span><span class="p p-Indicator">-</span><span class="w"> </span><span class="l l-Scalar l-Scalar-Plain">9012345678</span>
-<span class="w">      </span><span class="nt">all_aws_regions</span><span class="p">:</span><span class="w"> </span><span class="l l-Scalar l-Scalar-Plain">true</span>
+<span class="w">      </span><span class="p p-Indicator">-</span><span class="w"> </span><span class="nt">all_aws_regions</span><span class="p">:</span><span class="w"> </span><span class="l l-Scalar l-Scalar-Plain">true</span>
+<span class="w">        </span><span class="nt">account_ids</span><span class="p">:</span>
+<span class="w">          </span><span class="p p-Indicator">-</span><span class="w"> </span><span class="l l-Scalar l-Scalar-Plain">1234567890</span>
+<span class="w">          </span><span class="p p-Indicator">-</span><span class="w"> </span><span class="l l-Scalar l-Scalar-Plain">0123456789</span>
+<span class="w">          </span><span class="p p-Indicator">-</span><span class="w"> </span><span class="l l-Scalar l-Scalar-Plain">9012345678</span>
+
+<span class="p p-Indicator">-</span><span class="w"> </span><span class="nt">name</span><span class="p">:</span><span class="w"> </span><span class="l l-Scalar l-Scalar-Plain">Create organization aggregator</span>
+<span class="w">  </span><span class="nt">community.aws.config_aggregator</span><span class="p">:</span>
+<span class="w">    </span><span class="nt">name</span><span class="p">:</span><span class="w"> </span><span class="l l-Scalar l-Scalar-Plain">organization_aggregator</span>
+<span class="w">    </span><span class="nt">state</span><span class="p">:</span><span class="w"> </span><span class="l l-Scalar l-Scalar-Plain">present</span>
+<span class="w">    </span><span class="nt">organization_source</span><span class="p">:</span>
+<span class="w">      </span><span class="nt">role_arn</span><span class="p">:</span><span class="w"> </span><span class="s">&quot;arn:aws:iam::012345678910:role/AWSConfigRole&quot;</span>
 </pre></div>
 </div>
 <section id="authors">

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/565f9bd18d7d4c9781ba57ec6230c1b2

✔️ ansible-galaxy-importer SUCCESS in 4m 17s
✔️ build-ansible-collection SUCCESS in 12m 52s
ansible-test-sanity-docker-devel FAILURE in 13m 10s (non-voting)
ansible-test-sanity-docker-milestone FAILURE in 13m 00s (non-voting)
ansible-test-sanity-docker-stable-2.12 FAILURE in 13m 09s
ansible-test-sanity-docker-stable-2.13 FAILURE in 13m 25s
ansible-test-sanity-docker-stable-2.14 FAILURE in 12m 31s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 6m 56s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 7m 56s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 19s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 9m 09s
ansible-test-changelog FAILURE in 4m 32s
✔️ ansible-test-splitter SUCCESS in 4m 58s
✔️ integration-community.aws-1 SUCCESS in 5m 40s
Skipped 21 jobs

@rmahroua rmahroua changed the title Update to the Config aggregator module Update to the Config recorder module Jun 1, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/9e782dcc56ab481481ea655b55e8edf9

✔️ ansible-galaxy-importer SUCCESS in 4m 13s
✔️ build-ansible-collection SUCCESS in 12m 47s
ansible-test-sanity-docker-devel FAILURE in 12m 12s (non-voting)
ansible-test-sanity-docker-milestone FAILURE in 11m 55s (non-voting)
ansible-test-sanity-docker-stable-2.12 FAILURE in 12m 10s
ansible-test-sanity-docker-stable-2.13 FAILURE in 12m 27s
ansible-test-sanity-docker-stable-2.14 FAILURE in 12m 21s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 8m 34s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 8m 08s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 8m 17s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 9m 13s
✔️ ansible-test-changelog SUCCESS in 4m 32s
✔️ ansible-test-splitter SUCCESS in 5m 01s
✔️ integration-community.aws-1 SUCCESS in 8m 05s
Skipped 21 jobs

@rmahroua rmahroua changed the title Update to the Config recorder module Update to the Config aggregator module Jun 30, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/b4095b86612b4175ae2e23276cffe541

ansible-galaxy-importer FAILURE in 5m 19s (non-voting)
✔️ build-ansible-collection SUCCESS in 13m 28s
✔️ ansible-test-splitter SUCCESS in 5m 16s
✔️ integration-community.aws-1 SUCCESS in 6m 00s
Skipped 21 jobs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant