ecs_taskdefinition: use aws_retry to avoid throttling exception
#2124
Conversation
|
Build succeeded. ❌ ansible-galaxy-importer FAILURE in 4m 58s (non-voting) |
alinabuzachis
added
backport-7
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 8m 03s (non-voting) |
|
Build succeeded (gate pipeline). ❌ ansible-galaxy-importer FAILURE in 4m 49s (non-voting) |
softwarefactory-project-zuul
bot
merged commit 97131ec
into
ansible-collections:main
Backport to stable-7: 💚 backport PR created✅ Backport PR branch: Backported as #2128 🤖 @patchback |
) SUMMARY Fixes #2123 by adding aws_retry=True to the API calls. ISSUE TYPE Bugfix Pull Request COMPONENT NAME ecs_taskdefinition ADDITIONAL INFORMATION We observed that ecs_taskdefinition intermittently causes a ThrottlingException when running on a task definition with a large number of revisions. Looking at the code, it appears that describe_task_definitions loops over the revisions without using the retry mechanism. This PR attempts to solve the problem by adding aws_retry=True to the API calls. Due to the nature of the problem (intermittent throttling by AWS), I couldn't devise automated tests that validate the fix. Reviewed-by: Alina Buzachis Reviewed-by: Mark Chappell Reviewed-by: Eli Acherkan (cherry picked from commit 97131ec)
Backport to stable-8: 💚 backport PR created✅ Backport PR branch: Backported as #2129 🤖 @patchback |
) SUMMARY Fixes #2123 by adding aws_retry=True to the API calls. ISSUE TYPE Bugfix Pull Request COMPONENT NAME ecs_taskdefinition ADDITIONAL INFORMATION We observed that ecs_taskdefinition intermittently causes a ThrottlingException when running on a task definition with a large number of revisions. Looking at the code, it appears that describe_task_definitions loops over the revisions without using the retry mechanism. This PR attempts to solve the problem by adding aws_retry=True to the API calls. Due to the nature of the problem (intermittent throttling by AWS), I couldn't devise automated tests that validate the fix. Reviewed-by: Alina Buzachis Reviewed-by: Mark Chappell Reviewed-by: Eli Acherkan (cherry picked from commit 97131ec)
) (#2129) This is a backport of PR #2124 as merged into main (97131ec). SUMMARY Fixes #2123 by adding aws_retry=True to the API calls. ISSUE TYPE Bugfix Pull Request COMPONENT NAME ecs_taskdefinition ADDITIONAL INFORMATION We observed that ecs_taskdefinition intermittently causes a ThrottlingException when running on a task definition with a large number of revisions. Looking at the code, it appears that describe_task_definitions loops over the revisions without using the retry mechanism. This PR attempts to solve the problem by adding aws_retry=True to the API calls. Due to the nature of the problem (intermittent throttling by AWS), I couldn't devise automated tests that validate the fix. Reviewed-by: Markus Bergholz <[email protected]>
SUMMARY
Fixes #2123 by adding
aws_retry=Trueto the API calls.ISSUE TYPE
COMPONENT NAME
ecs_taskdefinition
ADDITIONAL INFORMATION
We observed that
ecs_taskdefinitionintermittently causes aThrottlingExceptionwhen running on a task definition with a large number of revisions. Looking at the code, it appears thatdescribe_task_definitionsloops over the revisions without using the retry mechanism. This PR attempts to solve the problem by addingaws_retry=Trueto the API calls.Due to the nature of the problem (intermittent throttling by AWS), I couldn't devise automated tests that validate the fix.