Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNM Migrate elb_classic_lb_info* modules and tests #2163

Conversation

mandar242
Copy link
Contributor

Depends-On: ansible-collections/amazon.aws#2315

Remove elb_classic_lb_info* modules and tests
These modules have been migrated to amazon.aws
Update runtime.yml with redirects to that collection
Update ignore files

Copy link

github-actions bot commented Sep 30, 2024

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

Copy link
Contributor

This change depends on a change that failed to merge.

Change ansible-collections/amazon.aws#2315 is needed.

@mandar242 mandar242 changed the title DNM Migrate elb_classic_lb_info* modules and tests Migrate elb_classic_lb_info* modules and tests Oct 2, 2024
@alinabuzachis alinabuzachis changed the title Migrate elb_classic_lb_info* modules and tests DNM Migrate elb_classic_lb_info* modules and tests Oct 4, 2024
Copy link
Contributor

This change depends on a change that failed to merge.

Change ansible-collections/amazon.aws#2315 is needed.

@mandar242 mandar242 added the mergeit Merge the PR (SoftwareFactory) label Oct 7, 2024
Copy link
Contributor

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

https://ansible.softwarefactory-project.io/zuul/buildset/033093855fe545e0abcb85e1989c93c2

Warning:
Change 2315 in project ansible-collections/amazon.aws does not share a change queue with 2163 in project ansible-collections/community.aws

@mandar242
Copy link
Contributor Author

regate

@mandar242 mandar242 added mergeit Merge the PR (SoftwareFactory) and removed mergeit Merge the PR (SoftwareFactory) labels Oct 7, 2024
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/d799855e9a6d4b31aab80874917b27e9

ansible-galaxy-importer FAILURE in 4m 49s (non-voting)
✔️ build-ansible-collection SUCCESS in 11m 34s
✔️ ansible-test-splitter SUCCESS in 5m 19s
✔️ integration-community.aws-1 SUCCESS in 13m 03s
Skipped 21 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 7f11acb into ansible-collections:main Oct 7, 2024
93 of 125 checks passed
mandar242 added a commit that referenced this pull request Oct 8, 2024
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Oct 10, 2024
…2170)

This reverts commit 7f11acb.
Reverts #2163
#2163 changes are being reverted as it has been agreed to hold off on merging the migration PRs until a plan is set to migrate all planned modules at once. We need to disable the squash strategy in github first to retain commit history.
SUMMARY

Reviewed-by: GomathiselviS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants