Refactoring #21
Merged
Refactoring #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ready for review |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #21 +/- ##
==========================================
+ Coverage 80.73% 81.85% +1.11%
==========================================
Files 2 3 +1
Lines 244 248 +4
Branches 37 36 -1
==========================================
+ Hits 197 203 +6
+ Misses 28 27 -1
+ Partials 19 18 -1 ☔ View full report in Codecov by Sentry. |
|
@Andersson007 Can the connection to clickhouse also be transferred to module_utils? |
we could try in another PR:) it's vacant:) |
aleksvagachev
approved these changes
Feb 7, 2024
|
@aleksvagachev thanks for reviewing and merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Refactoring to simplify further module development