Added integration testing against more versions of ClickHouse #22
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #22 +/- ##
==========================================
+ Coverage 80.73% 81.14% +0.40%
==========================================
Files 2 2
Lines 244 244
Branches 37 37
==========================================
+ Hits 197 198 +1
Misses 28 28
+ Partials 19 18 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
@aleksvagachev hi, sorry for the late reply! Was on Fosdem AFK
thanks, it's a great improvement!
| - 21.8.15.7 | ||
| - 22.8.9.24 | ||
| - 23.8.9.54 |
There was a problem hiding this comment.
| - 21.8.15.7 | |
| - 22.8.9.24 | |
| - 23.8.9.54 | |
| - 21.8.15.7 | |
| - 23.8.9.54 |
how about testing against the oldest supported and the newest ones?
i know now it's OK but when we add more python versions + maybe connector versions it can make a difference. What do you think?
There was a problem hiding this comment.
It's a good option, it just doesn't take into account the features of the intermediate version, we may miss something. Can we test with three versions up to version 1.0.0, then reduce it to two?
There was a problem hiding this comment.
sure, SGTM, we can always remove it later if needed
SUMMARY
Added integration testing against more versions of Clickhouse
The latest lts versions for 2021, 2022, 2023 have been selected for testing
Issue #20