Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clickhouse_client: Remove timedelta support #33

Merged

Conversation

Andersson007
Copy link
Contributor

SUMMARY

clickhouse_client: Remove timedelta support. Reasons:

  • There's a type interval that cannot be used as a column type
  • Let's not optimize prematurely
  • It also pulls an extra datetime lib loading

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (233b7be) 89.94% compared to head (89a4402) 89.91%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #33      +/-   ##
==========================================
- Coverage   89.94%   89.91%   -0.03%     
==========================================
  Files           5        5              
  Lines         368      367       -1     
  Branches       54       54              
==========================================
- Hits          331      330       -1     
  Misses         20       20              
  Partials       17       17              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Andersson007
Copy link
Contributor Author

ready for review

@aleksvagachev aleksvagachev merged commit e88a4be into ansible-collections:main Feb 15, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants