Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the collection of information settings_profiles, quotas #39

Merged
merged 2 commits into from
Feb 19, 2024
Merged

Added the collection of information settings_profiles, quotas #39

merged 2 commits into from
Feb 19, 2024

Conversation

aleksvagachev
Copy link
Collaborator

SUMMARY

Added the collection of information on quotas and settings_profiles

ISSUE TYPE
  • Feature Pull Request

Copy link

codecov bot commented Feb 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e33b2e7) 88.18% compared to head (3ce08c1) 90.12%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
+ Coverage   88.18%   90.12%   +1.93%     
==========================================
  Files           5        6       +1     
  Lines         381      415      +34     
  Branches       56       60       +4     
==========================================
+ Hits          336      374      +38     
+ Misses         26       24       -2     
+ Partials       19       17       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Andersson007 Andersson007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aleksvagachev great improvement, thanks!

One thing from me, please take a look

plugins/modules/clickhouse_info.py Outdated Show resolved Hide resolved
@Andersson007 Andersson007 merged commit 694c3d9 into ansible-collections:main Feb 19, 2024
23 checks passed
@aleksvagachev aleksvagachev deleted the patch2 branch February 22, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants