added option to disable flatten nested

[tmahany419]

SUMMARY

I could not find a way to run multiple queries from the same context using this module. There's no way to create a table with flatten_nested disabled without running multiple queries. This PR adds a field called flatten_nested for clickhouse_client that sets this setting before running the query.

ISSUE TYPE

• Feature Pull Request

COMPONENT NAME

Flatten Nested

ADDITIONAL INFORMATION

This is clickhouse's document explaining options for nested fields: https://clickhouse.com/docs/en/sql-reference/data-types/nested-data-structures/nested. The behavior with flatten_nested enabled and disabled is explained there. The only way to disable it is by running set flatten_nested=0; before creating a table.

[Andersson007]

@tmahany419 hello, thanks for the PR!
Could you also please:

• Add a changelog fragment
• Add a test task to https://github.com/ansible-collections/community.clickhouse/blob/main/tests/integration/targets/clickhouse_client/tasks/initial.yml

thanks

[tmahany419]

@Andersson007 Thank you for the feedback! I committed the changes you proposed. I've made unit test and it works against a local clickhouse db. I added it to the file you linked in the branch I am working on. Is there a way to test it before updating the PR?

[Andersson007]

@Andersson007 Thank you for the feedback! I committed the changes you proposed. I've made unit test and it works against a local clickhouse db. I added it to the file you linked in the branch I am working on. Is there a way to test it before updating the PR?

@tmahany419 thanks!
About testing, yes, you can run the tests locally before pushing, please take a look at https://docs.ansible.com/ansible/devel/community/create_pr_quick_start.html , there are corresponding sections there

[Andersson007]

@tmahany419 you still need to make CI green before we can consider merging the PR, try to start with merging my suggesting above, maybe it'll fix some failures

[tmahany419]

@Andersson007 I merged the change you mentioned. I've also added a test as requested.

[Andersson007]

@tmahany419 I don't see the tests, maybe you forgot to add a change to your commit?

[tmahany419]

@Andersson007 I updated the wrong branch yesterday, it should be there now.

[Andersson007]

@tmahany419 there's still unit tests failures but I'll fix them myself.
Thanks a lot for the contribution!
You're welcome in future for more contributions/feedback!

[aleksvagachev]

@Andersson007 Maybe it is more correct to implement the transfer of not a specific parameter, but the desired list of parameters?

[Andersson007]

@aleksvagachev good catch, something like the following

- name: Run the query
  community.clickhouse.clickhouse_client:
  query: SELECT ...
  set:
    flatten_nested: 0

?

[aleksvagachev]

@Andersson007 Yes, something similar. Shall we try to implement this in 1.0.0?

[Andersson007]

@Andersson007 Yes, something similar. Shall we try to implement this in 1.0.0?

@aleksvagachev as this change hasn't been released yet, we can do it right now. Thoughts? Would you like to take it?

[aleksvagachev]

@Andersson007 I'll try to do it, but not before Monday