Add services after -- and not before.

ansible-collections · Jul 25, 2024 · 12b10d0 · 12b10d0
1 parent e4819f9
commit 12b10d0
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/changelogs/fragments/942-compose-v2-pull.yml b/changelogs/fragments/942-compose-v2-pull.yml
@@ -1,3 +1,6 @@
 minor_changes:
   - "docker_compose_v2_pull - add new options ``ignore_buildable``, ``include_deps``, and ``services``
      (https://github.com/ansible-collections/community.docker/issues/941, https://github.com/ansible-collections/community.docker/pull/942)."
+bugfixes:
+  - "docker_compose_v2 - make sure that services provided in ``services`` are appended to the command line after ``--`` and not before it
+     (https://github.com/ansible-collections/community.docker/pull/942)."
diff --git a/plugins/modules/docker_compose_v2.py b/plugins/modules/docker_compose_v2.py
@@ -497,9 +497,9 @@ def get_up_cmd(self, dry_run, no_start=False):
             args.append('--no-start')
         if dry_run:
             args.append('--dry-run')
+        args.append('--')
         for service in self.services:
             args.append(service)
-        args.append('--')
         return args
 
     def cmd_up(self):
@@ -518,9 +518,9 @@ def get_stop_cmd(self, dry_run):
             args.extend(['--timeout', '%d' % self.timeout])
         if dry_run:
             args.append('--dry-run')
+        args.append('--')
         for service in self.services:
             args.append(service)
-        args.append('--')
         return args
 
     def _are_containers_stopped(self):
@@ -571,9 +571,9 @@ def get_restart_cmd(self, dry_run):
             args.extend(['--timeout', '%d' % self.timeout])
         if dry_run:
             args.append('--dry-run')
+        args.append('--')
         for service in self.services:
             args.append(service)
-        args.append('--')
         return args
 
     def cmd_restart(self):
@@ -598,9 +598,9 @@ def get_down_cmd(self, dry_run):
             args.extend(['--timeout', '%d' % self.timeout])
         if dry_run:
             args.append('--dry-run')
+        args.append('--')
         for service in self.services:
             args.append(service)
-        args.append('--')
         return args
 
     def cmd_down(self):