Use LooseVersion instead of StrictVersion to parse urllib3 versions.

ansible-collections · Jun 29, 2024 · fec81a0 · fec81a0
1 parent faf24fd
commit fec81a0
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/changelogs/fragments/902-loose-version.yml b/changelogs/fragments/902-loose-version.yml
@@ -0,0 +1,2 @@
+bugfixes:
+  - "vendored Docker SDK for Python - use ``LooseVersion`` instead of ``StrictVersion`` to compare urllib3 versions. This is needed for development versions (https://github.com/ansible-collections/community.docker/pull/902)."
diff --git a/plugins/module_utils/_api/transport/ssladapter.py b/plugins/module_utils/_api/transport/ssladapter.py
@@ -15,7 +15,7 @@
       https://github.com/kennethreitz/requests/pull/799
 """
 
-from ansible_collections.community.docker.plugins.module_utils.version import StrictVersion
+from ansible_collections.community.docker.plugins.module_utils.version import LooseVersion
 
 from .._import_helper import HTTPAdapter, urllib3
 from .basehttpadapter import BaseHTTPAdapter
@@ -66,4 +66,4 @@ def can_override_ssl_version(self):
             return False
         if urllib_ver == 'dev':
             return True
-        return StrictVersion(urllib_ver) > StrictVersion('1.5')
+        return LooseVersion(urllib_ver) > LooseVersion('1.5')
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		bugfixes:
		- "vendored Docker SDK for Python - use ``LooseVersion`` instead of ``StrictVersion`` to compare urllib3 versions. This is needed for development versions (https://github.com/ansible-collections/community.docker/pull/902)."