Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bad expressions in tests #711

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

felixfontein
Copy link
Collaborator

SUMMARY

Currently CI fails due to bad expressions. These were legal before, but are now forbidden. (Finally.)

ISSUE TYPE
  • Test Pull Request
COMPONENT NAME

various

@felixfontein felixfontein marked this pull request as ready for review November 28, 2023 21:52
@felixfontein felixfontein merged commit b8afdc5 into ansible-collections:main Nov 28, 2023
99 checks passed
@felixfontein felixfontein deleted the ci2 branch November 28, 2023 21:52
Copy link
Contributor

patchback bot commented Nov 28, 2023

Backport to stable-2: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply b8afdc5 on top of patchback/backports/stable-2/b8afdc52b1c70097453657def88d90f6a4fcab16/pr-711

Backporting merged PR #711 into main

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it:
    $ git remote add upstream https://github.com/ansible-collections/community.docker.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/stable-2/b8afdc52b1c70097453657def88d90f6a4fcab16/pr-711 upstream/stable-2
  4. Now, cherry-pick PR Fix bad expressions in tests #711 contents into that branch:
    $ git cherry-pick -x b8afdc52b1c70097453657def88d90f6a4fcab16
    If it'll yell at you with something like fatal: Commit b8afdc52b1c70097453657def88d90f6a4fcab16 is a merge but no -m option was given., add -m 1 as follows instead:
    $ git cherry-pick -m1 -x b8afdc52b1c70097453657def88d90f6a4fcab16
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR Fix bad expressions in tests #711 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/stable-2/b8afdc52b1c70097453657def88d90f6a4fcab16/pr-711
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

felixfontein added a commit to felixfontein/community.docker that referenced this pull request Nov 28, 2023
ci_complete

(cherry picked from commit b8afdc5)
felixfontein added a commit that referenced this pull request Nov 28, 2023
ci_complete

(cherry picked from commit b8afdc5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant