-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docker_compose_v2* modules: use --progress json
for Compose 2.29.0+
#931
docker_compose_v2* modules: use --progress json
for Compose 2.29.0+
#931
Conversation
status, | ||
text, | ||
) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The structured output is still somewhat messy, but that's unfortunately not a surprise if you look at how the events are created that the JSON progress dumps (the progress dumping itself is rather dumb, it does not do fancy transforms).
If someone ever wants to rewrite Compose again, I would suggest to start with a proper machine readable output before trying to make it look nice. That will avoid quite some messy progess events from the beginning...
(The tests likely didn't run with Compose 2.29.0 in CI so far since the release didn't happen that long ago. In a few days they should actually run with 2.29.0. I locally ran the tests with a self-compiled Compose 2.29.0 and there they seem to pass, if I didn't screw up anything :) ) |
b9746ac
to
bf62bb3
Compare
(Arch Linux already has compose 2.29.0 out by now, so it should be used in the tests.) |
I moved the last commit to #932 and will rebase once that's merged. |
--progress json
for Compose 2.29.0+
114eb8d
to
af1cb0e
Compare
Hmm I want to test this more thouroughly and potentially add more warnings (like for non-JSON lines). |
104829c
to
3dae320
Compare
3dae320
to
969e0a0
Compare
TODO: support |
The failing check is unrelated... |
45b2531
into
ansible-collections:main
SUMMARY
Compose 2.29.0 is out: https://github.com/docker/compose/releases/tag/v2.29.0
It features
--progress json
output (docker/compose#11478), which makes it easier to parse its output.ISSUE TYPE
COMPONENT NAME
docker_compose_v2*