Skip to content

Commit

Permalink
redfish_utils: remove undocumented default applytime (#9114)
Browse files Browse the repository at this point in the history
* redfish_utils: remove undocumented default applytime

The `@Redfish.OperationApplyTime` parameter is optional as per Redfish
spec version 1.21.0, paragraph 7.11 [1]. Some systems reject the
request rather than ignore it, causing failures that can not be
workarounded.

Removing this default resolves compatibility issues.

[1] https://www.dmtf.org/sites/default/files/standards/documents/DSP0266_1.21.0.html

Signed-off-by: Tan Siewert <[email protected]>

* redfish_utils: fix changelog fragment to bugfix

Signed-off-by: Tan Siewert <[email protected]>

---------

Signed-off-by: Tan Siewert <[email protected]>
  • Loading branch information
sinuscosinustan authored Nov 11, 2024
1 parent d27d86e commit bafb8ac
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
bugfixes:
- redfish_utils module utils - remove undocumented default applytime (https://github.com/ansible-collections/community.general/pull/9114).
2 changes: 1 addition & 1 deletion plugins/module_utils/redfish_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -1958,7 +1958,7 @@ def multipath_http_push_update(self, update_opts):
update_uri = data['MultipartHttpPushUri']

# Assemble the JSON payload portion of the request
payload = {"@Redfish.OperationApplyTime": "Immediate"}
payload = {}
if targets:
payload["Targets"] = targets
if apply_time:
Expand Down

0 comments on commit bafb8ac

Please sign in to comment.