Skip to content

Commit

Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(nmcli): remove bond from ip_conn_type
Browse files Browse the repository at this point in the history
By `bond` connections being included in the `ip_conn_type` list, the
resulting `nmcli` commands include references to `ipv4` and `ipv6`
settings. These options are not available to `bond` connection types as
stated by the error output in issue #8558.

Closes #8558
joey-grant committed Aug 7, 2024
1 parent 132faea commit e82c8f7
Showing 2 changed files with 2 additions and 1 deletion.
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
minor_changes:
- "nmcli - corrects underlying command formation by no longer including ``ipv4.*`` and ``ipv6.*`` settings when working with ``bond`` connection types (https://github.com/ansible-collections/community.general/issues/8558)."
1 change: 0 additions & 1 deletion plugins/modules/nmcli.py
Original file line number Diff line number Diff line change
@@ -1951,7 +1951,6 @@ def connection_options(self, detect_change=False):
@property
def ip_conn_type(self):
return self.type in (
'bond',
'bridge',
'dummy',
'ethernet',

0 comments on commit e82c8f7

Please sign in to comment.