Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests/unit/requirements.txt for maven_artifact #314

Conversation

felixfontein
Copy link
Collaborator

SUMMARY

One part of #296 I forgot to include into #306: make sure that semantic_version is included in unit test requirements. (It is included in the default docker container for Ansible 2.10, but not for 2.9.)

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

tests/unit/requirements.txt

@felixfontein felixfontein requested a review from Andersson007 May 9, 2020 08:45
@ansibullbot ansibullbot added affects_2.10 bug This issue/PR relates to a bug tests tests labels May 9, 2020
Copy link
Contributor

@Andersson007 Andersson007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
shipit

@felixfontein felixfontein merged commit d2b6857 into ansible-collections:master May 9, 2020
@felixfontein felixfontein deleted the requirements.txt-maven_artifacts branch May 9, 2020 09:03
@felixfontein
Copy link
Collaborator Author

@Andersson007 thanks for reviewing :)

@Andersson007
Copy link
Contributor

@felixfontein you're always welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants