gitlab_project_members: Added group sharing and unsharing logic for issue #8658 #8676

Acarnesecchi · 2024-07-25T10:04:31Z

SUMMARY

Modifies the ansible_project_members module to add the possibility to share and unshare projects with one or more groups. This is supported both by the API and the python-gitlab library.

Fix #8658

ISSUE TYPE

gitlab_project_members.py

ADDITIONAL INFORMATION

ansibullbot · 2024-07-25T10:07:55Z

@Acarnesecchi this PR contains the following merge commits:

da5c912

Please rebase your branch to remove these commits.

click here for bot help

Acarnesecchi · 2024-07-25T17:06:58Z

@felixfontein I am trying to reach out to someone on libera.chat IRC but apparently I am not allowed to send messages in #ansible-devel channel. What can I do?
I have already rebased my fork so it's up-to-date but all commits are squashed.

felixfontein · 2024-07-25T19:21:32Z

@Acarnesecchi please ignore the IRC part of the bot's message, you don't need to ask any core team member there (this is a collection, not ansible-core; and also the problem here isn't that a core review is needed).

The main problem here is that your commit contains a lot of changes that don't belong to this PR and shouldn't be in there. If you check out the Files tab of this PR you can see what I mean: https://github.com/ansible-collections/community.general/pull/8676/files

Acarnesecchi · 2024-07-25T19:47:14Z

@felixfontein my fork is clean now, please, let me know if anything else is needed. Thx!

ansibullbot · 2024-07-25T20:09:10Z

cc @Lunik @Shaps @lgatellier @marwatk @metanovii @nejch @scodeman @sh0shin @suukit @waheedi @zanssa
click here for bot help

felixfontein

Thanks for your contribution! Can you please add a changelog fragment? Thanks.

plugins/modules/gitlab_project_members.py

felixfontein · 2024-07-27T07:42:50Z

plugins/modules/gitlab_project_members.py

+    type: list
+    elements: dict
+    suboptions:
+      name:


I would use two different fields for ID and name, instead of having to figure out whether a string is an ID or a name.

All the other modules that use the group variable work with both ID and name. I would leave it as it is for consistency

I don't know whether it's this way in the other modules for backwards compatibility, or because it is the best solution. I hope that some of the GitLab module maintainers can weight in here.

@Lunik @Shaps @lgatellier @marwatk @metanovii @nejch @scodeman @sh0shin @suukit @waheedi @zanssa can someone of you take a look at this?

plugins/modules/gitlab_project_members.py

felixfontein · 2024-07-27T07:48:24Z

plugins/modules/gitlab_project_members.py

+    elif module.params['gitlab_group'] is not None:
+        gitlab_groups = module.params['gitlab_group']
+        groups = project.get_groups_in_a_project(gitlab_project_id)
+    if groups:


This condition looks wrong to me. If module.params['gitlab_group'] is not None but groups happens to be empty, the below cases are handled, and eventually the module exits with "Nothing to do, please give at least one user or group or set purge_users true.". That doesn't sound right to me.

This problem is still there. Just because the module argument is not None doesn't mean the list is not empty.

felixfontein · 2024-07-27T07:49:23Z

plugins/modules/gitlab_project_members.py

    changed_data = []

-    for gitlab_user in gitlab_users_access:
-        gitlab_user_id = project.get_user_id(gitlab_user['name'])
+    if members:


This condition also looks suspicious.

russoz

hi @Acarnesecchi thanks for your contribution!

I got a couple of comments there, nothing major.

russoz · 2024-12-17T05:29:08Z

plugins/modules/gitlab_project_members.py

+        for gid in groups:
+            if gid == group_id:
+                return True
+        return False


More pythonic as:

Suggested change

for gid in groups:

if gid == group_id:

return True

return False

return any(group_id == gid for gid in groups)

russoz · 2024-12-17T05:30:07Z

plugins/modules/gitlab_project_members.py

+            options=dict(
+                name=dict(type='str', required=True),
+                group_access_level=dict(type='str', choices=[
+                    'guest', 'reporter', 'developer', 'maintainer'], required=False),


Redundant

Suggested change

'guest', 'reporter', 'developer', 'maintainer'], required=False),

'guest', 'reporter', 'developer', 'maintainer']),

This comment was marked as outdated.

Sign in to view

ansibullbot added ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Jul 25, 2024

felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-9 Automatically create a backport for the stable-9 branch labels Jul 25, 2024

felixfontein changed the title ~~Added group sharing and unsharing logic for issue #8658~~ gitlab_project_members: Added group sharing and unsharing logic for issue #8658 Jul 25, 2024

This comment was marked as outdated.

Sign in to view

Acarnesecchi force-pushed the main branch from 23457e2 to 82cc837 Compare July 25, 2024 16:21

This comment was marked as outdated.

Sign in to view

ansibullbot removed ci_verified Push fixes to PR branch to re-run CI merge_commit This PR contains at least one merge commit. Please resolve! labels Jul 25, 2024

Acarnesecchi force-pushed the main branch 2 times, most recently from 2b973da to 175a8fc Compare July 25, 2024 16:45

Acarnesecchi closed this Jul 25, 2024

Acarnesecchi force-pushed the main branch from 175a8fc to 3a24aa5 Compare July 25, 2024 19:38

Acarnesecchi reopened this Jul 25, 2024

ansibullbot added plugins plugin (any type) and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Jul 25, 2024

felixfontein reviewed Jul 27, 2024

View reviewed changes

Acarnesecchi force-pushed the main branch 2 times, most recently from 0d429ae to 79cc6d7 Compare July 27, 2024 10:19

ansibullbot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Jul 27, 2024

Acarnesecchi closed this Jul 27, 2024

Acarnesecchi force-pushed the main branch from 79cc6d7 to 1a8f172 Compare July 27, 2024 10:20

Acarnesecchi reopened this Jul 27, 2024

ansibullbot removed the needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI label Jul 27, 2024

Acarnesecchi force-pushed the main branch from 635fbf8 to 0967941 Compare July 27, 2024 10:37

ansibullbot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR label Jul 27, 2024

This comment was marked as outdated.

Sign in to view

ansibullbot added merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html labels Jul 29, 2024

Acarnesecchi force-pushed the main branch from 20536cd to 0967941 Compare July 29, 2024 09:11

Acarnesecchi closed this Jul 29, 2024

Acarnesecchi force-pushed the main branch from 0967941 to 37c8560 Compare July 29, 2024 09:12

added option to share projects with a group

a243ecc

Acarnesecchi reopened this Jul 29, 2024

Acarnesecchi requested a review from felixfontein July 29, 2024 09:23

ansibullbot removed merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html labels Jul 29, 2024

ansibullbot added the stale_ci CI is older than 7 days, rerun before merging label Aug 9, 2024

felixfontein removed the backport-9 Automatically create a backport for the stable-9 branch label Oct 7, 2024

russoz reviewed Dec 18, 2024

View reviewed changes

ansibullbot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Jan 3, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

gitlab_project_members: Added group sharing and unsharing logic for issue #8658 #8676

gitlab_project_members: Added group sharing and unsharing logic for issue #8658 #8676

Acarnesecchi commented Jul 25, 2024

ansibullbot commented Jul 25, 2024

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

Acarnesecchi commented Jul 25, 2024

felixfontein commented Jul 25, 2024

Acarnesecchi commented Jul 25, 2024 •

edited

Loading

ansibullbot commented Jul 25, 2024

felixfontein left a comment

felixfontein Jul 27, 2024

Acarnesecchi Jul 27, 2024

felixfontein Aug 5, 2024

felixfontein Oct 27, 2024

felixfontein Jul 27, 2024

felixfontein Aug 5, 2024

felixfontein Jul 27, 2024

This comment was marked as outdated.

russoz left a comment

russoz Dec 17, 2024

russoz Dec 17, 2024

	'guest', 'reporter', 'developer', 'maintainer'], required=False),
	'guest', 'reporter', 'developer', 'maintainer']),

gitlab_project_members: Added group sharing and unsharing logic for issue #8658 #8676

Are you sure you want to change the base?

gitlab_project_members: Added group sharing and unsharing logic for issue #8658 #8676

Conversation

Acarnesecchi commented Jul 25, 2024

SUMMARY

ISSUE TYPE

ADDITIONAL INFORMATION

ansibullbot commented Jul 25, 2024

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

Acarnesecchi commented Jul 25, 2024

felixfontein commented Jul 25, 2024

Acarnesecchi commented Jul 25, 2024 • edited Loading

ansibullbot commented Jul 25, 2024

felixfontein left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

This comment was marked as outdated.

russoz left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Acarnesecchi commented Jul 25, 2024 •

edited

Loading