Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxmox module refactoring #9225

Merged
merged 6 commits into from
Jan 26, 2025
Merged

Proxmox module refactoring #9225

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0c87d71
proxmox: Refactor
Lithimlin Dec 6, 2024
c9599b4
proxmox: Fix changelog fragment, doc, and deprecation string formatting.
Lithimlin Jan 21, 2025
7c6daa0
proxmox: Fix formatting in imports
Lithimlin Jan 21, 2025
2d0da2d
proxmox: require one of `vmid` or `hostname`, simplify checks
Lithimlin Jan 21, 2025
8836a53
proxmox: apply check for supported features to entire module
Lithimlin Jan 21, 2025
d00d61f
proxmox: move parameter conversions inside create and update functions
Lithimlin Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions changelogs/fragments/9225-proxmox-module-refactoring.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
minor_changes:
- proxmox - refactors the proxmox module (https://github.com/ansible-collections/community.general/pull/9225)
- proxmox - fixes idempotency of template conversions (https://github.com/ansible-collections/community.general/pull/9225, https://github.com/ansible-collections/community.general/issues/8811).
Lithimlin marked this conversation as resolved.
Show resolved Hide resolved
- proxmox - fixes issues with disk_volume variable (https://github.com/ansible-collections/community.general/pull/9225, https://github.com/ansible-collections/community.general/issues/9065).
- proxmox - fixes incorrect parsing for bind-only mounts (https://github.com/ansible-collections/community.general/pull/9225, https://github.com/ansible-collections/community.general/issues/8982).
- proxmox module utils - fixes ignoring of ``choose_first_if_multiple`` argument in ``get_vmid`` (https://github.com/ansible-collections/community.general/pull/9225)
Lithimlin marked this conversation as resolved.
Show resolved Hide resolved

deprecated_features:
- proxmox - removes default value of ``update`` parameter. This will be changed to a default of ``true`` in the future (https://github.com/ansible-collections/community.general/pull/9225)
Lithimlin marked this conversation as resolved.
Show resolved Hide resolved
2 changes: 1 addition & 1 deletion plugins/module_utils/proxmox.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ def get_vmid(self, name, ignore_missing=False, choose_first_if_multiple=False):
return None

self.module.fail_json(msg='No VM with name %s found' % name)
elif len(vms) > 1:
elif len(vms) > 1 and not choose_first_if_multiple:
self.module.fail_json(msg='Multiple VMs with name %s found, provide vmid instead' % name)

return vms[0]
Expand Down
Loading
Loading