locale_gen: fix/improvements #9238
Open
+121
−78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
WIP
felixfontein
added
check-before-release
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
russoz
force-pushed
the
locale-gen-rewrite
branch
from
0bff56e to
2840fd3
Compare
This comment was marked as resolved.
This comment was marked as resolved.
- add changelog fragment - improved docs
russoz
changed the title
|
Hi @ltog @samikhelil83 @lukasz-zaroda Could you please review the PR? Thanks in advance! Happy holidays! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
It introduces a RV
mechanismthat declares the mode in a more descriptive way:Refer to #9131 (comment) for a more complete rationale.
Change the logic to determine whether
ubuntu_modeisTrueorFalse.Formerly it would:
ubuntu_mode=Trueif/var/lib/locales/supported.dexisted,Falseif/etc/locale.genexists,With this PR it will:
ubuntu_mode=Falseis/etc/locale.genis present,Trueif the/var/lib/...directory exists,Canonical made a deliberate decision to move towards the glibc support, so all Ubuntu versions since 16.04 have
/etc/locale.gen. I have tested locally in Debian 11 and 12 and both of them worked using glibc mode.The PR will include tests forcing
ubuntu_mode=True.Fixes #8487 #9131
ISSUE TYPE
COMPONENT NAME
locale_gen