-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plugins (become, callback, filter): style adjustments #9535
plugins (become, callback, filter): style adjustments #9535
Conversation
plugins/inventory/gitlab_runners.py
Outdated
host: https://gitlab.com | ||
- example 1: | | ||
plugin: community.general.gitlab_runners | ||
host: https://gitlab.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure these should be formatted this way.
Optimally one would use different YAML documents for every example, but ansible-test barfs on that.
How about not changing the inventory examples for now? I think using YAML documents is the better solution, but that's something to explore in another PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the inventory plugins from this PR, will work with them in a separate one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please split up that PR in one that modifies everything but examples, and one that modifies the examples? I'd really lke to get everything but the examples done ASAP (it basically was already done in this PR, I reviewed everything but inventory examples).
Backport to stable-9: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 3af793c on top of patchback/backports/stable-9/3af793c2c14679004fbceec041d551df1cc8389a/pr-9535 Backporting merged PR #9535 into main
🤖 @patchback |
@russoz thanks! |
Backport to stable-10: 💚 backport PR created✅ Backport PR branch: Backported as #9545 🤖 @patchback |
* plugins (become, callback, filter, inventory): style adjustments * remove inventory plugins from PR * adjustments from review * typo (cherry picked from commit 3af793c)
…lter): style adjustments (#9545) plugins (become, callback, filter): style adjustments (#9535) * plugins (become, callback, filter, inventory): style adjustments * remove inventory plugins from PR * adjustments from review * typo (cherry picked from commit 3af793c) Co-authored-by: Alexei Znamensky <[email protected]>
SUMMARY
Second round of doc adjustments. Output width has been slightly reduced in andebox, and a couple of other style improvements have been added (like replacing id with ID)
ISSUE TYPE
COMPONENT NAME
plugins/become/pfexec.py
plugins/callback/default_without_diff.py
plugins/callback/yaml.py
plugins/filter/accumulate.py
plugins/filter/counter.py
plugins/filter/crc32.py
plugins/filter/dict.py
plugins/filter/dict_kv.py
plugins/filter/from_csv.py
plugins/filter/from_ini.py
plugins/filter/groupby_as_dict.py
plugins/filter/jc.py
plugins/filter/json_query.py
plugins/filter/keep_keys.py
plugins/filter/lists_mergeby.py
plugins/filter/random_mac.py
plugins/filter/remove_keys.py
plugins/filter/replace_keys.py
plugins/filter/reveal_ansible_type.py
plugins/filter/to_ini.py
plugins/filter/unicode_normalize.py
plugins/filter/version_sort.py