use open() as context manager #9579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
module
|
The changes in |
felixfontein
added
check-before-release
felixfontein
approved these changes
Jan 18, 2025
felixfontein
removed
the
check-before-release
Backport to stable-10: 💚 backport PR created✅ Backport PR branch: Backported as #9596 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Jan 21, 2025
* use open() as context manager * add changelog frag (cherry picked from commit 0de39a6)
felixfontein
pushed a commit
that referenced
this pull request
Jan 21, 2025
…#9596) use open() as context manager (#9579) * use open() as context manager * add changelog frag (cherry picked from commit 0de39a6) Co-authored-by: Alexei Znamensky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Use open as a context manager, as a good practice.
ISSUE TYPE
COMPONENT NAME
plugins/module_utils/known_hosts.py
plugins/modules/cloud_init_data_facts.py
plugins/modules/cronvar.py
plugins/modules/crypttab.py
plugins/modules/parted.py
plugins/modules/pulp_repo.py
plugins/modules/redhat_subscription.py
plugins/modules/solaris_zone.py
plugins/modules/sorcery.py
plugins/modules/timezone.py
tests/unit/plugins/inventory/test_iocage.py
tests/unit/plugins/modules/test_wdc_redfish_command.py