apache2-mod-proxy: better handling regexp extraction #9609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixfontein
added
check-before-release
felixfontein
approved these changes
Jan 23, 2025
| @@ -246,7 +246,7 @@ class BalancerMember(object): | |||
| """ | |||
|
|
|||
| def __init__(self, management_url, balancer_url, module): | |||
| self.host = regexp_extraction(management_url, str(EXPRESSION), 4) | |||
| self.host = regexp_extraction(management_url, EXPRESSION, 4) | |||
| self.management_url = str(management_url) | |||
| self.protocol = regexp_extraction(management_url, EXPRESSION, 3) | |||
| self.port = regexp_extraction(management_url, EXPRESSION, 5) | |||
There was a problem hiding this comment.
This function is seaching for the same regex in the same string four times, every time using a different group of the result. That looks very inefficient to me... I guess this could be improved at some point :)
felixfontein
removed
the
check-before-release
Backport to stable-10: 💚 backport PR created✅ Backport PR branch: Backported as #9616 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Jan 23, 2025
* apache2-mod-proxy: better handling regexp extraction * add changelog frag (cherry picked from commit bf5c7f8)
|
@russoz thanks! |
felixfontein
pushed a commit
that referenced
this pull request
Jan 23, 2025
…dling regexp extraction (#9616) apache2-mod-proxy: better handling regexp extraction (#9609) * apache2-mod-proxy: better handling regexp extraction * add changelog frag (cherry picked from commit bf5c7f8) Co-authored-by: Alexei Znamensky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Improve the handling of the data extraction using regexp by pre-compiling the regular expressions.
ISSUE TYPE
COMPONENT NAME
apache2_mod_proxy