Skip to content

[stable-2] mysql_role: new module (#189) #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Andersson007
Copy link
Collaborator

(cherry picked from commit ce2b269)

SUMMARY

[stabl-2] mysql_role: new module (#189)

ISSUE TYPE
  • Feature Pull Request

* mysql_role: new module

* fixes

* fixes

* Add the role class

* Check if role exists

* role.add()

* role.__get_members

* tmp

* tmp

* Change tests

* Fix

* Fix

* add_members()

* get_privs()

* tmp

* __extract_grants() filler version

* Before big work

* tmp

* drop()

* tmp

* tmp

* Big changes

* Fix

* append_members, detach_members, append_privs

* tmp

* admin option

* Add tests

* Add tests

* Fix tests

* Remove debug warning

* Fix tests

* Add documentation

* Fix MariaDB case

* Fix MariaDB

* Fix MariaDB

* Fix MariaDB

* Fix MariaDB

* Fix MariaDB

* Fix

* Fix

* Remove debug warning

* Add try-except block

* tmp

* tmp

* tmp

* Fix

* Add err handling

* Add user check

* Check admin in db

* Fix CI

* Fix CI

* Fix CI

* Fix CI

* Fix

* Add mutually exclusive options

* Small refactoring, documenting

* Documenting, refactoring

* Change docs

* Refactoring

* Refactoring

* Refactoring

* Add unit tests

* Update README.md

(cherry picked from commit ce2b269)
@codecov
Copy link

codecov bot commented Aug 11, 2021

Codecov Report

Merging #200 (78a2b9a) into stable-2 (fa62fd3) will increase coverage by 0.58%.
The diff coverage is 82.01%.

Impacted file tree graph

@@             Coverage Diff              @@
##           stable-2     #200      +/-   ##
============================================
+ Coverage     76.92%   77.51%   +0.58%     
============================================
  Files            20       24       +4     
  Lines          1794     2161     +367     
  Branches        439      508      +69     
============================================
+ Hits           1380     1675     +295     
- Misses          268      319      +51     
- Partials        146      167      +21     
Impacted Files Coverage Δ
plugins/modules/mysql_role.py 80.39% <80.39%> (ø)
plugins/module_utils/user.py 81.46% <81.46%> (ø)
plugins/module_utils/implementations/mysql/role.py 100.00% <100.00%> (ø)
plugins/modules/mysql_user.py 79.38% <100.00%> (-3.21%) ⬇️
tests/unit/plugins/module_utils/test_mysql_user.py 100.00% <100.00%> (ø)
tests/unit/plugins/modules/test_mysql_role.py 100.00% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa62fd3...78a2b9a. Read the comment docs.

@Andersson007 Andersson007 changed the title [stabl-2] mysql_role: new module (#189) [stable-2] mysql_role: new module (#189) Aug 11, 2021
@Andersson007 Andersson007 merged commit a8e2c52 into ansible-collections:stable-2 Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant