Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ansible-core stable-2.15 and stable-2.16 to tests matrix now that "devel" links to 2.17 #574

Conversation

laurent-indermuehle
Copy link
Collaborator

@laurent-indermuehle laurent-indermuehle commented Sep 19, 2023

SUMMARY

Add ansible-core 2.15 and 2.16 to the sanity, integration and unit tests matrix now that "devel" links to ansible-core 2.17. This is in response to this announcement

ISSUE TYPE
  • CI
COMPONENT NAME

CI

ADDITIONAL INFORMATION

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (9439282) 76.96% compared to head (167a1dd) 74.17%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #574      +/-   ##
==========================================
- Coverage   76.96%   74.17%   -2.79%     
==========================================
  Files          28       18      -10     
  Lines        2379     2254     -125     
  Branches      579      560      -19     
==========================================
- Hits         1831     1672     -159     
- Misses        389      411      +22     
- Partials      159      171      +12     
Flag Coverage Δ
integration 73.60% <ø> (-0.14%) ⬇️
sanity ?
units ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 19 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@laurent-indermuehle
Copy link
Collaborator Author

Question, should I backport this to stable-2?
I read that Ansible maintains 4 major releases. Should I drop tests for 2.12?

@laurent-indermuehle
Copy link
Collaborator Author

Ok, 2.12 is EOL. And 2.13 will be in a month: https://docs.ansible.com/ansible-core/devel/reference_appendices/release_and_maintenance.html#ansible-core-support-matrix.

Instead of this PR, and because dropping support for older version is a major change we should release c.mysql 4.0 right!? I've never done that before. Maybe I should wait for @Andersson007 to come back in case we need special privileges on this repo to do that.

@laurent-indermuehle
Copy link
Collaborator Author

Also, as seen in this sanity test: https://github.com/ansible-collections/community.mysql/actions/runs/6236980470/job/16929520017?pr=572
ansible-core 2.17 comes with more tests and we have documentations mismatch to fix.
The checks from this PR probably didn't tests anything because of the option pull-request-change-detection: true.

How should we do things properly then?

  1. Start a pre-release-4 version (How? Just create a new branch?)
  2. Cut ansible-core 2.12 and 2.13 from tests matrix
  3. Run all tests against all files
  4. Fix any sanity, integration and unit tests issues
  5. Release stable-4

Copy link
Collaborator

@Andersson007 Andersson007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@laurent-indermuehle thanks a lot!

@laurent-indermuehle
Copy link
Collaborator Author

We discussed this with @Andersson007 on Matrix and decided to drop support for ansible-core 2.12 and 2.13 and not create a major release for this. But we announce a major change.
I just did that. Hope we are good to merge now.

@laurent-indermuehle laurent-indermuehle merged commit 8c2b6b0 into ansible-collections:main Sep 29, 2023
39 of 47 checks passed
@laurent-indermuehle
Copy link
Collaborator Author

Forgot to mention: fix #528

@laurent-indermuehle laurent-indermuehle deleted the lie_add_ansible_core_2_15_and_2_16_to_tests branch September 29, 2023 12:57
laurent-indermuehle added a commit to laurent-indermuehle/community.mysql that referenced this pull request Oct 3, 2023
… "devel" links to 2.17 (ansible-collections#574)

* Add stable-2.15 and 2.16 now that devel link to 2.17

* document which ansible-core version we support

* add sanity ignore for ansible-core 2.17

* cut sanity ignore for 2.12 and 2.13

* Cut ansible-core 2.12 and 2.13 from GHA test matrix
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Nov 17, 2023
v8.6.1

Bugfixes
--------

netapp.ontap

- na_ontap_dns - fix keyerror for uuid when DNS is set to vserver in REST.
- na_ontap_volume - fix invalid field error with 'space.snapshot.autodelete' in REST.


v8.6.0

Major Changes
-------------

community.mysql

- The community.mysql collection no longer supports ``ansible-core 2.12`` and ``ansible-core 2.13``. While we take no active measures to prevent usage and there are no plans to introduce incompatible code to the modules, we will stop testing those versions. Both are or will soon be End of Life and if you are still using them, you should consider upgrading to the ``latest Ansible / ansible-core 2.15 or later`` as soon as possible (ansible-collections/community.mysql#574).
- mysql_role - the ``column_case_sensitive`` argument's default value will be changed to ``true`` in community.mysql 4.0.0. If your playbook expected the column to be automatically uppercased for your roles privileges, you should set this to false explicitly (ansible-collections/community.mysql#578).
- mysql_user - the ``column_case_sensitive`` argument's default value will be changed to ``true`` in community.mysql 4.0.0. If your playbook expected the column to be automatically uppercased for your users privileges, you should set this to false explicitly (ansible-collections/community.mysql#577).

fortinet.fortios

- Add new fortios version 7.4.1.
- Format the contents in the changelog.yml file.
- Update Ansible version from 2.9 to 2.14.
- Update Q&A with a resolution for Ansible Always Sending GET/PUT Requests as POST Requests.
- Update the requirement.txt file to specify the sphinx_rtd_theme==1.3.0
- update the required Ansible version to 2.14.0 in the runtime.yml file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants