Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix user plugin changes in check mode #596

Merged
merged 31 commits into from
Aug 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
1aef4d7
Fix user plugin changes in check mode
francescsanjuanmrf Nov 20, 2023
f4136a1
Add auth plugin tests
francescsanjuanmrf Aug 23, 2024
6e18324
Undo local changes
francescsanjuanmrf Aug 23, 2024
9537caf
Improve task names
francescsanjuanmrf Aug 23, 2024
896f93d
Fix query
francescsanjuanmrf Aug 23, 2024
585ddd6
Changes
francescsanjuanmrf Aug 23, 2024
3b388eb
Add check
francescsanjuanmrf Aug 23, 2024
28daad7
Add check
francescsanjuanmrf Aug 23, 2024
e0f5462
Add check
francescsanjuanmrf Aug 23, 2024
3325643
Add one more check
francescsanjuanmrf Aug 23, 2024
5b923a3
Add one more check
francescsanjuanmrf Aug 23, 2024
17a88ac
Fix typo
francescsanjuanmrf Aug 23, 2024
31bdc49
Change parameter
francescsanjuanmrf Aug 23, 2024
9fa9bb7
Testing
francescsanjuanmrf Aug 23, 2024
829c381
Remove tests
francescsanjuanmrf Aug 26, 2024
e97324a
Add tests
francescsanjuanmrf Aug 26, 2024
a5250f2
Test first stteps
francescsanjuanmrf Aug 26, 2024
4ea8502
Readd tests
francescsanjuanmrf Aug 26, 2024
2575eae
Test without check mode
francescsanjuanmrf Aug 26, 2024
2386175
Test with check mode
francescsanjuanmrf Aug 26, 2024
725f0d9
Test with check mode
francescsanjuanmrf Aug 26, 2024
681d5ac
Testing
francescsanjuanmrf Aug 26, 2024
e5ad446
Testing
francescsanjuanmrf Aug 26, 2024
f1155fa
Add missing tests
francescsanjuanmrf Aug 26, 2024
02b0de8
Changes for ansible-lint complaints
francescsanjuanmrf Aug 26, 2024
4526833
Fix condition
francescsanjuanmrf Aug 26, 2024
6e094ce
Update changelogs/fragments/596-fix-check-changes.yaml
francescsanjuanmrf Aug 28, 2024
8e78265
refactor
francescsanjuanmrf Aug 28, 2024
a9b97b4
Add more tests
francescsanjuanmrf Aug 28, 2024
6dab807
Fix newpass var
francescsanjuanmrf Aug 28, 2024
017d072
Remove extra test
francescsanjuanmrf Aug 28, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/fragments/596-fix-check-changes.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
bugfixes:
- mysql_user - module makes changes when is executed with ``plugin_auth_string`` parameter and check mode.
3 changes: 2 additions & 1 deletion plugins/module_utils/user.py
Original file line number Diff line number Diff line change
Expand Up @@ -411,7 +411,8 @@ def user_mod(cursor, user, host, host_all, password, encrypted,
else:
query_with_args = "ALTER USER %s@%s IDENTIFIED WITH %s", (user, host, plugin)

cursor.execute(*query_with_args)
if not module.check_mode:
cursor.execute(*query_with_args)
Andersson007 marked this conversation as resolved.
Show resolved Hide resolved
password_changed = True
changed = True

Expand Down
Loading
Loading