[CI] Add 2024 versions to tests #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansible-test uses python 3.10 if we specify ubuntu2204. Thus we lose the ability to chose specific version of python to test. But integrations tests are optional for a collection. And we don't catch a issue with Python that often (ever ? I don't recall seen one). This allow us to test MySQL 8.4, so it's a win.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #660 +/- ##
===========================================
+ Coverage 65.51% 76.18% +10.66%
===========================================
Files 20 19 -1
Lines 2627 2624 -3
Branches 673 673
===========================================
+ Hits 1721 1999 +278
+ Misses 697 426 -271
+ Partials 209 199 -10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This is puzzling me. Why when using ansible devel the python command changes? I know ansible-test install python after starting ubuntu22.04 so the way python is install must changes.
Comment on lines
+63
to
+68
| - '0.9.3' | ||
| - '1.0.2' | ||
| - '1.1.1' | ||
| - '2.0.1' | ||
| - '2.0.3' | ||
| - '2.1.1' |
There was a problem hiding this comment.
Suggested change
| - '0.9.3' | |
| - '1.0.2' | |
| - '1.1.1' | |
| - '2.0.1' | |
| - '2.0.3' | |
| - '2.1.1' | |
| - '0.9.3' | |
| - '1.0.2' | |
| - '1.1.1' | |
| - '2.0.1' | |
| - '2.0.3' | |
| - '2.1.1' |
can we also apply same oldest-supported-and-newest strategy here?
There was a problem hiding this comment.
Best way to install PyMySQL is to use the distribution's package manager.
The version depends on the will of the APT/RPM maintainers:
- Ubuntu 22.04 : 1.0.2
- RHEL8 : 0.10.1
- RHEL9 : 1.1.1
- Fedora39 : 1.1.0-3 and 1.1.1-1
So we can't say: "This 1.0.2 bug was fixed in 1.1.1, please update", if their distribution doesn't provide such package.
We won't save that many VMs anyway. And PyMySQL is not updated that often: https://pypi.org/project/PyMySQL/#history
When reading log we tend to look at the bottom, but doing so we find often a idempotent error that are nothing to do with the first error. Disabling this can greatly speedup tests and makes logs more readable. Plus, now GHA jumps automatically at the latest error message. So with this modification, we will always jump to the latest real error message.
We can't expand the left column on GHA, so the shorter, the better. Use Ⓐ instead of Ansible.
|
Ready for review please. |
Andersson007
approved these changes
Jul 19, 2024
laurent-indermuehle
merged commit c503dc5
into
ansible-collections:main
40 of 46 checks passed
laurent-indermuehle
added a commit
to laurent-indermuehle/community.mysql
that referenced
this pull request
Jul 19, 2024
* Enable mysql_native_password for MySQL 8.2+ * Fix connection to MySQL 8 since Ubuntu 20.04 update * Cut mysqlclient form the documentation * Cut tests for Python 3.12 not supported by ansible-test * Upgrade integration controller to ubuntu2204 by removing python ansible-test uses python 3.10 if we specify ubuntu2204. Thus we lose the ability to chose specific version of python to test. But integrations tests are optional for a collection. And we don't catch a issue with Python that often (ever ? I don't recall seen one). This allow us to test MySQL 8.4, so it's a win. * Cut tests for EoL MariaDB 10.4 * Reduce number of test in the matrix * Cut support for intermediate LTS * Fix python command not found with ansible-devel and add the debug This is puzzling me. Why when using ansible devel the python command changes? I know ansible-test install python after starting ubuntu22.04 so the way python is install must changes. * Disable retry-on-error When reading log we tend to look at the bottom, but doing so we find often a idempotent error that are nothing to do with the first error. Disabling this can greatly speedup tests and makes logs more readable. Plus, now GHA jumps automatically at the latest error message. So with this modification, we will always jump to the latest real error message. * Enhance jobs title readability We can't expand the left column on GHA, so the shorter, the better. Use Ⓐ instead of Ansible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
fixes #624
fixes #625
Removes tests for specific version of Python
why:
Remove tests for
Add tests for
Update tests
Number of VM
Note for MySQL 8.4
Since MySQL 8.2, the mysql_native_plugin is absent. I modified the Makefile and GHA workflow to add the option to enable it back. Otherwise our tests fails to connect to the database.
Other tests are now failing due to deprecated option between 8.0 and 8.4 but I intend to let the tests red here and open a new PR to fix issues with MySQL 8.4 later.
Note for MySQL 8.0
One week ago, our CI stopped working. This is because Ubuntu 20.04 got updated for security reasons and now mysql-client complains that 'cryptography' package is missing. The upgrade to ubuntu 22.04 fix that.
Note for MySQL 9 and MariaDB 11
None of the latest db engine have a LTS release. So we will wait a little longer before testing those versions.
ISSUE TYPE
COMPONENT NAME