Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: add stable-2.18, fix README #681

Merged
merged 5 commits into from
Sep 26, 2024

Conversation

Andersson007
Copy link
Collaborator

SUMMARY

CI: add stable-2.18, fix README

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.59%. Comparing base (28bf709) to head (e5c2729).

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #681       +/-   ##
===========================================
+ Coverage   25.74%   76.59%   +50.84%     
===========================================
  Files          32       20       -12     
  Lines        2808     2657      -151     
  Branches      704      679       -25     
===========================================
+ Hits          723     2035     +1312     
+ Misses       2044      420     -1624     
- Partials       41      202      +161     
Flag Coverage Δ
integration 75.95% <ø> (?)
sanity ?
units ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Andersson007
Copy link
Collaborator Author

ready for review

Copy link
Collaborator

@laurent-indermuehle laurent-indermuehle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw the announcement from Felix Fontein the other day. But you're faster than me, we are lucky to have you @Andersson007!

I propose to remove 2.15 to gain time. Other than that, ok to merge.

.github/workflows/ansible-test-plugins.yml Outdated Show resolved Hide resolved
.github/workflows/ansible-test-plugins.yml Outdated Show resolved Hide resolved
.github/workflows/ansible-test-plugins.yml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@Andersson007
Copy link
Collaborator Author

I saw the announcement from Felix Fontein the other day. But you're faster than me, we are lucky to have you @Andersson007!

I propose to remove 2.15 to gain time. Other than that, ok to merge.

@laurent-indermuehle SGTM, merged, thanks, PTAL

@Andersson007 Andersson007 merged commit a5afa1a into ansible-collections:main Sep 26, 2024
57 checks passed
@Andersson007
Copy link
Collaborator Author

@laurent-indermuehle thanks for reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants