Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve integration testing #79

Open
Andersson007 opened this issue Jul 16, 2021 · 8 comments
Open

Improve integration testing #79

Andersson007 opened this issue Jul 16, 2021 · 8 comments
Labels
help wanted Extra attention is needed

Comments

@Andersson007
Copy link
Contributor

Andersson007 commented Jul 16, 2021

SUMMARY

To make things going in the collection, CI, that failed, was simplified with #78

I can't invest much time as not a maintainer of this collection and not a specialist in the area.

Would be nice:

  1. Get rid of the simplification introduced with Fix CI #78 replacing it with corresponding Ansible tasks. Uncomment # - stage: Docker_2_9 in .azure-pipelines/azure-pipelines.yml

  2. Add ubuntu 16.04 back to .azure-pipelines/azure-pipelines.yml against to all the branches except devel

  3. The CI triggers many distributions (like Fedora, CentOS, Suse, etc.) but tests actually run only on Ubuntu. I disabled them to reduce load on CI system. We could a) remove them from the test matrix or b) implement tests for them (for what? I think rabbitmq versions are actually important)

  4. Would be nice to run tests against several versions of rabbitmq (starting with the oldest supported and finishing with the latest one).

This was referenced Jul 16, 2021
@Andersson007 Andersson007 added the help wanted Extra attention is needed label Jul 16, 2021
@Andersson007
Copy link
Contributor Author

cc @cognifloyd
Let's track the progress in this issue

@petebuffon
Copy link

I'm currently in the process of adding ansible-collections-community-rabbitmq to both Fedora and CentOS. It would help me out if there were tests for both of these distributions.

I would be willing to help write these tests, but I'm not exactly sure where to start.

@Andersson007
Copy link
Contributor Author

@petebuffon hello, thanks for your interest!
You could start with:

If there are any questions, feel free to ask, thanks!

@Im0
Copy link
Collaborator

Im0 commented Oct 24, 2022

Might be worth considering removing shippable/posix like in ansible-collections/community.docker#484 and perhaps some of utils/shippable could be tidied up? (Check other repo's)

@Andersson007
Copy link
Contributor Author

Might be worth considering removing shippable/posix like in ansible-collections/community.docker#484 and perhaps some of utils/shippable could be tidied up? (Check other repo's)

Sure

@Im0
Copy link
Collaborator

Im0 commented Oct 31, 2022

4. Would be nice to run tests against several versions of rabbitmq (starting with the oldest supported and finishing with the latest one).

To this point. Perhaps we should test 3.9, 3.10 and 3.11 of rabbitmq. Details here: https://www.rabbitmq.com/versions.html
Or, just test 3.9 and 3.11?

Something to be mindful of is the different erlang requirements for different versions: https://www.rabbitmq.com/which-erlang.html

@Im0
Copy link
Collaborator

Im0 commented Nov 1, 2022

@Andersson007 are most collections utilising github workflows these days? Is it strange/undesirable for community.rabbitmq to be using AZP? Or OK?

@Andersson007
Copy link
Contributor Author

@Im0 it's OK

  • GHA is used for distro-independent testing (its big downside is that currently it runs all available test targets regardless of files changed... which resp. increases the time needed for runs to pass)
  • AZP is used when we need to test against different distros (though if you use only one distro, it's OK)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants