Update the integration setup playbook #75
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abompard
force-pushed
the
integration-tests
branch
from
8c969c9 to
a572df9
Compare
|
azure pipelines says that logs are kept for 3 days, so I'm going to copy the relevant parts of the error output in here so I don't lose them. Sorry for the really long message. It looks like the errors are ubuntu version-specific. 16 has an issue with the signing key and 18 has an issue resolving which packages to install. CI (Docker 2.9 Ubuntu 16.04) -> Run TestsCI (Docker 2.10 Ubuntu 16.04) -> Run TestsCI (Docker 2.9 Ubuntu 18.04) -> Run TestsCI (Docker 2.10 Ubuntu 18.04) -> Run TestsCI (Docker 2.11 Ubuntu 18.04) -> Run TestsCI (Docker devel Ubuntu 18.04) -> Run Tests |
|
@abompard Are these the same errors you saw last time? It sounds like they are different. In #72 (comment) you said:
|
|
Ubuntu 16 is EOL (since April 30th), so maybe we should:
|
|
Also, RabbitMQ only supports: "Ubuntu 18.04 through 21.04" so we really should drop ubuntu 16. |
cognifloyd
requested changes
Jul 15, 2021
Comment on lines
49
to
50
| #update_cache: yes | ||
| update_cache: no |
There was a problem hiding this comment.
why did you disable update_cache? This might be (part of) why it's getting so many package conflicts.
Suggested change
| #update_cache: yes | |
| update_cache: no | |
| update_cache: yes |
Comment on lines
57
to
58
| #update_cache: yes | ||
| update_cache: no |
There was a problem hiding this comment.
Suggested change
| #update_cache: yes | |
| update_cache: no | |
| update_cache: yes |
| - erlang-crypto | ||
| - erlang-public-key | ||
| - erlang-ssl | ||
| name: rabbitmq-server |
There was a problem hiding this comment.
The docs say to use --fix-missing when installing rabbitmq-server, so I believe we need to use state:fixed here.
Suggested change
| name: rabbitmq-server | |
| name: rabbitmq-server | |
| state: fixed |
|
@cognifloyd hi, would you like to create a PR to update the playbook yourself? I'd be happy to review and merge it |
|
@abompard do you have time / with to finish it? |
abompard
force-pushed
the
integration-tests
branch
from
a572df9 to
6dc7d41
Compare
The [installation instructions](https://www.rabbitmq.com/install-debian.html) have changed, these updates allow the integration container to build and run the tests. Signed-off-by: Aurélien Bompard <[email protected]>
abompard
force-pushed
the
integration-tests
branch
from
6dc7d41 to
6c53462
Compare
Signed-off-by: Aurélien Bompard <[email protected]>
abompard
force-pushed
the
integration-tests
branch
from
6c53462 to
c796be2
Compare
|
I may have some time but I'm also unfamiliar with the ansible testing framework and the Azure pipelines. So if someone else wants to take over I'll gladly pass it on :-) I just want CI to work so I can contribute some feature to the rabbitmq modules. |
abompard
changed the title
|
@abompard thanks for the feedback! How about the changes that @cognifloyd suggested? |
|
I applied them and force pushed |
|
@abompard i think this PR can be closed since i made a temporary (hehe) solution #78. Thank you for the attempt! If anyone is interested in improving the CI, welcome #79 @abompard @cognifloyd thanks! |
|
I just saw all your messages.
@Andersson007 LOL - disabling all the envs is quite the hack. Sure, I can create another PR to fix this stuff. |
|
Just looked at the test results. How encouraging :) so, my suggested fixes fixed Ubuntu 18 + ansible 2.10, 2.11, and devel. The fixes did not make Ubuntu 18 + ansible 2.9 work, however. Also, Ubuntu 20 didn't work. I figure we can enable one set of distros in each PR until we get them all working. |
Yes, it is:) Though the tests were actually running only on Ubuntu. And the errors on Ubuntu 16 / 18 didn't seem to relate to the modules themselves.
Would be really cool! Ping me there for review.
Acting gradually sounds sensible to me. I'll close this PR then. @abompard would be nice if you take part in the future PRs dedicated to fixing the CI. It is really important for stability of this stuff. The many eyes / opinios, the better. Thank you! |
cognifloyd
added a commit
to cognifloyd/community.rabbitmq
that referenced
this pull request
Jul 31, 2021
New process as documented upstream. Follows the general outline developed in ansible-collections#75
Andersson007
pushed a commit
that referenced
this pull request
Aug 10, 2021
* Test Ubuntu 20.04 * Test on CentOS 7 * Revert "Test on CentOS 7" This reverts commit 346dc97. * enable ansible 2.9 integration tests * drop ansible 2.9 integration tests again * use include_tasks in setup_rabbitmq test role * Update integration test role setup_rabbitmq New process as documented upstream. Follows the general outline developed in #75 * Rename ubuntu.yml to Ubuntu.yml * first_found fix * drop duplicate task * drop hack install script * reenable ansible 2.9 integration tests * configure before installing rabbitmq-server * disable service start on apt-get install * update libssl1.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The installation instructions have changed, these updates allow the integration container to build and run the tests.