Fixing bug whereby a queue name with a slash in it resulted in a REST API error

[Im0]

SUMMARY

Fixes #114 - If a queue name was specified with a / in it, this resulted in a REST API error. Also, took the chance to add a documentation example for providing arguments.

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

rabbitmq_queue

ADDITIONAL INFORMATION

[Im0]

CI is failing on unrelated issue which is being worked on in #139

@cognifloyd @odyssey4me @jgkirschbaum if anyone could take a quick look/review it would be appreciated. Thanks :)

[Im0]

TODO:
* tests/integration/targets/rabbitmq_publish/tasks/ubuntu.yml - unsure why this was deleted... will put back in.
* tests/integration/targets/rabbitmq_queue/tasks/ubuntu.yml - First task mentions pika... remove comment about pika.

[Andersson007]

@Im0 thanks for the bugfix!

one formatting thing from me

@csmart @odyssey4me @cognifloyd do you have any opinions on the patch?

[Im0]

Thanks @Andersson007 ! Other rabbitmq_* modules had this issue previously and appear to also have been corrected with urllib_parse.quote(module.params['name'], ''). With the additional tests in place this is low risk in my opinion. Hopefully we can get the tick from one more reviewer as I'd like to release v1.2.3 of the collection asap. :)

[Andersson007]

@Im0 SGTM, thanks! if no objections, i think it's OK if you merge it tomorrow

[Andersson007]

@Im0 so, as there are no objections, feel free to merge

[Im0]

Thanks @Andersson007

[Andersson007]

@Im0 thanks for the contribution!
Just a fyi if once you get bored with doing only rabbitmq stuff (though there's a lot at the moment), there are many other opportunities to contribute.
Besides other collections, see the Contributor Path for details.
If there are any question, I'd be always happy to clarify them here or via email.
Thanks!