Fixes rabbitmq_binding breaks idempotency if arguments is not empty #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
will fix the sanitization tomorrow |
oneoneonepig
force-pushed
the
oneoneonepig-patch-20231030
branch
from
fa1766e to
8040101
Compare
|
Hi @oneoneonepig thanks for this contribution! Any chance you could please rebase and also add some more information in the commit message about the problem this is solving, and add a changelog snippet? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #160
ISSUE TYPE
COMPONENT NAME
community.rabbitmq.rabbitmq_binding
ADDITIONAL INFORMATION
Tested locally by running the same task twice. The second run shows all test cases
[ok]: .... See issue #160 to see what test cases were included.