Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Added the missing init for the rest client #1953

Conversation

valentinJonev
Copy link
Contributor

SUMMARY

Added a missing init

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

vcenter_root_password_expiration

ADDITIONAL INFORMATION

@valentinJonev
Copy link
Contributor Author

Hey @mariolenz can you please have a look?

@mariolenz
Copy link
Collaborator

recheck

@mariolenz
Copy link
Collaborator

recheck

@mariolenz
Copy link
Collaborator

mariolenz commented Dec 27, 2023

@valentinJonev I'm trying to create an integration test for this module: #1955

But it failed with:

"msg": "state is present but all of the following are missing: email"

I don't know why. The module doesn't define the email parameter as required. And according to the documentation it should be optional.

Well, I'll add the email parameter to the integration test for now. But maybe you could have a look at this and if the API really wants to have this, make it a required parameter.

Copy link
Collaborator

@mariolenz mariolenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@valentinJonev But please have a look at my last comment.

@mariolenz mariolenz added bug This issue/PR relates to a bug mergeit labels Dec 27, 2023
Copy link

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/151b0d39e29e4d12a1991bcda1fa9d9a

✔️ ansible-tox-linters SUCCESS in 9m 45s
✔️ build-ansible-collection SUCCESS in 7m 54s
✔️ ansible-galaxy-importer SUCCESS in 4m 21s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 9f69ea4 into ansible-collections:main Dec 27, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug mergeit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants