Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vmware_guest_tools_upgrade: New parameter installer_options #1958

Merged

Conversation

mariolenz
Copy link
Collaborator

SUMMARY

Fixes #1059

Add parameter installer_options to pass command line options to the installer to modify the installation procedure for tools.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

vmware_guest_tools_upgrade

ADDITIONAL INFORMATION

@ihumster
Copy link
Collaborator

ihumster commented Jan 5, 2024

Yesterday I was thinking about how to do this correctly - you came up with a quite elegant solution!

@mariolenz
Copy link
Collaborator Author

Yesterday I was thinking about how to do this correctly - you came up with a quite elegant solution!

I think it's more versatile and useful to add a new parameter installer_options. This way, people can add the option to supress a reboot but also any other ones they might need.

@mariolenz mariolenz changed the title [WIP] vmware_guest_tools_upgrade: New parameter installer_options vmware_guest_tools_upgrade: New parameter installer_options Jan 12, 2024
@mariolenz mariolenz added feature This issue/PR relates to a feature request has_issue mergeit labels Jan 12, 2024
Copy link

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/278e84fca5724f5da3761af56c163624

✔️ ansible-tox-linters SUCCESS in 10m 02s
✔️ build-ansible-collection SUCCESS in 7m 57s
✔️ ansible-galaxy-importer SUCCESS in 3m 53s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit efb78f5 into ansible-collections:main Jan 12, 2024
17 of 19 checks passed
@mariolenz mariolenz deleted the issue1059 branch January 12, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This issue/PR relates to a feature request has_issue mergeit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: vmware_guest_tools_upgrade to be applied without forcing reboot
2 participants