Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix InsecureRequestWarning #1969

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Fix InsecureRequestWarning #1969

merged 1 commit into from
Jan 18, 2024

Conversation

mariolenz
Copy link
Collaborator

@mariolenz mariolenz commented Jan 14, 2024 •
edited
Loading

SUMMARY

It looks like we're sometimes running into an InsecureRequestWarning.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

plugins/module_utils/vmware_rest_client.py

ADDITIONAL INFORMATION

Vmware ssl certs (works in one module, not the other!)

@mariolenz mariolenz force-pushed the 20240114_validate_certs branch from 145f9a2 to 6db1186 Compare January 14, 2024 18:56
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/d0f7e94c20d140baaab3fb23df26bab0

✔️ ansible-tox-linters SUCCESS in 9m 45s
✔️ build-ansible-collection SUCCESS in 10m 55s
❌ ansible-test-cloud-integration-vcenter7_only-stable216 FAILURE in 11m 47s
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable216 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable216_1_of_2 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable216_2_of_2 CANCELED
✔️ ansible-galaxy-importer SUCCESS in 4m 32s

@mariolenz mariolenz force-pushed the 20240114_validate_certs branch from 6db1186 to 414a1a5 Compare January 15, 2024 16:19
@mariolenz mariolenz force-pushed the 20240114_validate_certs branch from 414a1a5 to 315b9f3 Compare January 15, 2024 16:50
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/050beb51932d49729b9cbbcaebf9cd37

✔️ ansible-tox-linters SUCCESS in 9m 46s
✔️ build-ansible-collection SUCCESS in 10m 20s
✔️ ansible-test-cloud-integration-vcenter7_only-stable216 SUCCESS in 19m 51s
❌ ansible-test-cloud-integration-vcenter7_2esxi-stable216 FAILURE in 24m 09s
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable216_1_of_2 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable216_2_of_2 CANCELED
✔️ ansible-galaxy-importer SUCCESS in 4m 47s

@mariolenz
Copy link
Collaborator Author

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/8cc0fe5b11014c61aae1e887e58db3bf

✔️ ansible-tox-linters SUCCESS in 9m 41s
✔️ build-ansible-collection SUCCESS in 10m 22s
✔️ ansible-test-cloud-integration-vcenter7_only-stable216 SUCCESS in 18m 23s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable216 SUCCESS in 21m 11s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable216_1_of_2 SUCCESS in 57m 20s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable216_2_of_2 SUCCESS in 1h 07m 04s
✔️ ansible-galaxy-importer SUCCESS in 3m 26s

@mariolenz mariolenz changed the title [WIP] Fix InsecureRequestWarning Fix InsecureRequestWarning Jan 18, 2024
@mariolenz
Copy link
Collaborator Author

Looks like this really fixes the issue :-)

@mariolenz mariolenz added bug This issue/PR relates to a bug mergeit labels Jan 18, 2024
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/ffdabf9b93264fe9847c47b5ae3b0c27

✔️ ansible-tox-linters SUCCESS in 9m 43s
✔️ build-ansible-collection SUCCESS in 7m 56s
✔️ ansible-galaxy-importer SUCCESS in 4m 08s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 9c02d89 into ansible-collections:main Jan 18, 2024
11 checks passed
@mariolenz mariolenz deleted the 20240114_validate_certs branch January 18, 2024 17:08
mariolenz added a commit to mariolenz/community.vmware that referenced this pull request Jan 18, 2024
@mariolenz
Fix InsecureRequestWarning for VmwareRestClient based modules (ansibl…
7402055 
…e-collections#1969)

Fix InsecureRequestWarning

SUMMARY
It looks like we're sometimes running into an InsecureRequestWarning.
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
plugins/module_utils/vmware_rest_client.py
ADDITIONAL INFORMATION
Vmware ssl certs (works in one module, not the other!)
mariolenz added a commit to mariolenz/community.vmware that referenced this pull request Jan 18, 2024
@mariolenz
Fix InsecureRequestWarning for VmwareRestClient based modules (ansibl…
c954b2f 
…e-collections#1969)

Fix InsecureRequestWarning

SUMMARY
It looks like we're sometimes running into an InsecureRequestWarning.
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
plugins/module_utils/vmware_rest_client.py
ADDITIONAL INFORMATION
Vmware ssl certs (works in one module, not the other!)
@mariolenz mariolenz mentioned this pull request Jan 18, 2024
Merged
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Jan 18, 2024
@mariolenz
Fix InsecureRequestWarning for VmwareRestClient based modules (#1969) (…
5f59a93 
…#1970)

stable-3.x: Fix InsecureRequestWarning for VmwareRestClient based modules

SUMMARY
Backport of #1969
It looks like we're sometimes running into an InsecureRequestWarning.
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
plugins/module_utils/vmware_rest_client.py
ADDITIONAL INFORMATION
Vmware ssl certs (works in one module, not the other!)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug This issue/PR relates to a bug mergeit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mariolenz