Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use shared workflow for Galaxy import test #1975

Conversation

mariolenz
Copy link
Collaborator

SUMMARY

Use shared workflow from https://github.com/ansible-community/github-action-test-galaxy-import.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

CI

ADDITIONAL INFORMATION

Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/9fe3bcba1ec44b559a2d03f665b99f92

✔️ ansible-tox-linters SUCCESS in 9m 37s
✔️ build-ansible-collection SUCCESS in 10m 10s
✔️ ansible-galaxy-importer SUCCESS in 4m 35s

@mariolenz
Copy link
Collaborator Author

@felixfontein Does this look OK to you? If yes, I would merge and you could add community.vmware to ansible/zuul-config#539.

Copy link
Contributor

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Adding this collection to ansible/zuul-config#539 doesn't really work though, since it has a more complex Zuul configuration - see the Zuul comment above. Regular community collections do not get such comments.

You need to modify https://github.com/ansible/zuul-config/blob/a070803790f81a959cdc54e4d03840da8b0b3601/zuul.d/projects.yaml#L143-L151, and probably replace publish-to-galaxy there with publish-to-galaxy-plain. No idea how that influences gating though, which still seems to be configured for this collection.

@mariolenz
Copy link
Collaborator Author

Thanks for reviewing @felixfontein!

I think I'll merge it (which can easily be undone since it's "only" CI) and will have a look at what I can do about the Zuul jobs later.

@mariolenz mariolenz added CI CI related issues owner_pr PR created by owner/maintainer mergeit labels Jan 21, 2024
Copy link

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/8ed6df15b2214555a711feb51c8298d2

✔️ ansible-tox-linters SUCCESS in 9m 46s
✔️ build-ansible-collection SUCCESS in 8m 24s
✔️ ansible-galaxy-importer SUCCESS in 4m 29s

Copy link

Pull request merge failed: Resource not accessible by integration, You may need to manually rebase your PR and retry.

@mariolenz mariolenz merged commit aacf239 into ansible-collections:main Jan 21, 2024
13 checks passed
@mariolenz mariolenz deleted the use_shared_test-galaxy-import_workflow branch January 21, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CI related issues mergeit owner_pr PR created by owner/maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants