-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add timeout options to zabbix_settings #1427
Add timeout options to zabbix_settings #1427
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1427 +/- ##
==========================================
+ Coverage 78.08% 78.17% +0.09%
==========================================
Files 46 46
Lines 5685 5756 +71
Branches 1433 1474 +41
==========================================
+ Hits 4439 4500 +61
Misses 775 775
- Partials 471 481 +10 ☔ View full report in Codecov by Sentry. |
Please execute |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I approved this PR. however, please test all parameters for 6.4 or lower if you can . |
I've added the rest of the new parameters to the <7.0 tests |
Sorry. I want you to check these patterns.
because your tests cannot check all errors. |
Okay, there should be a test for each of the new parameters |
Thank you to update tests! |
SUMMARY
Zabbix 7.0 added several new settings for timeouts (timeout_zabbix_agent, timeout_simple_check, etc) and these are currently missing in the zabbix_settings module. This PR adds them in
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION
An example of using one of the timeouts is below