Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeout options to zabbix_settings #1427

Merged
merged 9 commits into from
Dec 25, 2024

Conversation

aplathrop
Copy link
Contributor

SUMMARY

Zabbix 7.0 added several new settings for timeouts (timeout_zabbix_agent, timeout_simple_check, etc) and these are currently missing in the zabbix_settings module. This PR adds them in

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
  • zabbix_settings
ADDITIONAL INFORMATION

An example of using one of the timeouts is below

- community.zabbix.zabbix_settings:
    timeout_zabbix_agent: 3s

@aplathrop aplathrop marked this pull request as ready for review December 3, 2024 16:30
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 85.91549% with 10 lines in your changes missing coverage. Please review.

Project coverage is 78.17%. Comparing base (645a81a) to head (bd59ba4).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
plugins/modules/zabbix_settings.py 85.91% 0 Missing and 10 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1427      +/-   ##
==========================================
+ Coverage   78.08%   78.17%   +0.09%     
==========================================
  Files          46       46              
  Lines        5685     5756      +71     
  Branches     1433     1474      +41     
==========================================
+ Hits         4439     4500      +61     
  Misses        775      775              
- Partials      471      481      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@masa-orca
Copy link
Collaborator

masa-orca commented Dec 6, 2024

Please execute git pull --rebase origin/main.
The checks errors might be resolved using 645a81a commit.

plugins/modules/zabbix_settings.py Outdated Show resolved Hide resolved
aplathrop and others added 3 commits December 6, 2024 10:53

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link
Collaborator

@masa-orca masa-orca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@masa-orca
Copy link
Collaborator

I approved this PR. however, please test all parameters for 6.4 or lower if you can .

@aplathrop
Copy link
Contributor Author

I've added the rest of the new parameters to the <7.0 tests

@masa-orca
Copy link
Collaborator

masa-orca commented Dec 10, 2024

Sorry. I want you to check these patterns.

- name: test - timeout_zabbix_agent parameter fail for older version of Zabbix
  community.zabbix.zabbix_settings:
    timeout_zabbix_agent: 3s

- name: test - timeout_simple_check parameter fail for older version of Zabbix
  community.zabbix.zabbix_settings:
    timeout_simple_check: 30s
    
 - name: test - timeout_snmp_agent parameter fail for older version of Zabbix
  community.zabbix.zabbix_settings:
    timeout_snmp_agent: 30s
....

because your tests cannot check all errors.
Warnings about this is written in https://github.com/ansible-collections/community.zabbix/pull/1427/checks?check_run_id=34134135951

@aplathrop
Copy link
Contributor Author

Okay, there should be a test for each of the new parameters

@masa-orca masa-orca merged commit 4c3966f into ansible-collections:main Dec 25, 2024
41 checks passed
@masa-orca
Copy link
Collaborator

Thank you to update tests!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants