-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zabbix 7.2 support #1442
Zabbix 7.2 support #1442
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1442 +/- ##
==========================================
+ Coverage 78.40% 78.49% +0.09%
==========================================
Files 47 47
Lines 5848 5873 +25
Branches 1491 1499 +8
==========================================
+ Hits 4585 4610 +25
- Misses 780 782 +2
+ Partials 483 481 -2 ☔ View full report in Codecov by Sentry. |
Thanks for the fix, can we get this PR merged as soon as possible? |
thanks for the work, a merge would be awsome :) |
Thanks for this PR! Everything looks great. Could we get this merged? |
This would be awesome, a merge would be welcomed! |
@D3DeFi @ragingpastry @BGmot @pyrodie18 @lzadjsf @mu1f407 any ETA on when this will be merged and a new version released? As of now the currently community.zabbix release does not work with Zabbix 7.2 |
Hi there, |
SUMMARY
This PR adds support for Zabbix 7.2. There are some changes in httpapi plugin which simplifies the code. Fixes modules where tests failed.
Fixes #1431
ISSUE TYPE
COMPONENT NAME
All modules (except inventory plugin)
ADDITIONAL INFORMATION
Notable code changes in httpapi plugin (beside of 7.2 support):
self.connection._auth
for request headers. It makes possible to remove{'auth': 'fake'}
conditions.api_version()
in thelogin
method. It is more clear replacement for try-except block inlogin
. We now also need to know Zabbix version because it has to be decided ifauth
should be sent in body orAuthorization: Bearer
should be in the header.