-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ospf area bugfix #466
Ospf area bugfix #466
Conversation
# clearing some of the settings in stub but not all | ||
# commands has to be a subset of have and whatever in it is translated into requests | ||
return False, requests, False | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, none of the "settings" were getting cleared for the problem case, so this comment isn't completely accurate.
Also, the wording of the existing comment was confusing.
Suggested re-wording for this comment:
Not all stub configuration is being deleted. (It is also possible that none of the stub options requested for deletion match any current configuration. In that case, no stub configuration is being deleted.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The proposed code change and corresponding test results look good.
I am posting only a request for re-wording of the comment related to the modified section of code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the incremental edit of the comment for the affected section of code.
All current proposed changes and test results look good.
Thanks for finding and fixing this bug.
Approved.
SUMMARY
Fixed bug in delete method where there was no condition handling the case of no requests to delete.
ISSUE TYPE
COMPONENT NAME
sonic_ospf_area
OUTPUT
failing report:
regression-2024-10-10-13-44-49.html.pdf
Passing report after change:
regression-2024-10-10-14-42-02.html.pdf
Checklist: