-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cable_length attribute to QoS interfaces module #468
base: main
Are you sure you want to change the base?
Conversation
plugins/module_utils/network/sonic/argspec/qos_interfaces/qos_interfaces.py
Outdated
Show resolved
Hide resolved
Co-authored-by: stalabi1 <[email protected]>
Co-authored-by: stalabi1 <[email protected]>
…interfaces.py Co-authored-by: stalabi1 <[email protected]>
Co-authored-by: stalabi1 <[email protected]>
Co-authored-by: stalabi1 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am posting one minor change request.
Also, as we discussed, please post on this PR the regression test html output obtained by including the "test_reports" role in the list of test roles provided in the "tests/regression/test.yaml" file that you use for running the regression test. (Please "print" it in "landscape" mode to create the PDF file to be attached to the PR, scaled so the output all fits on the page.)
plugins/module_utils/network/sonic/facts/qos_interfaces/qos_interfaces.py
Show resolved
Hide resolved
Done. Please see updated log file |
SUMMARY
Add 'cable_length' attribute to QoS interfaces module
ISSUE TYPE
COMPONENT NAME
sonic_qos_interfaces
ADDITIONAL INFORMATION
Checklist:
How Has This Been Tested?
Regression test with updated testcases. (12/3/2024)
regression-2024-12-03-15-05-49.zip