Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add_at_the_documentation_about_known_issues #1284

Closed
wants to merge 12 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
trivial:
- zos_blockinfile - Add information about known issues in notes.
(https://github.com/ansible-collections/ibm_zos_core/pull/1284).
- zos_lineinfile - Add information about known issues in notes.
(https://github.com/ansible-collections/ibm_zos_core/pull/1284).
4 changes: 4 additions & 0 deletions plugins/modules/zos_blockinfile.py
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,10 @@
the block will be overwritten on each iteration.
- When more then one block should be handled in a file you must change
the I(marker) per task.
- With ZOAU version 1.3.0, if double quotes (") are used in the I(block) parameter, the module
fails with an error message containing: 'return content is NOT in json format'. This is currently a
false negative response, where the I(src) is changed, but an error is reported anyhow. Follow up on the issue tracked
L(issue in the collection's repository,https://github.com/ansible-collections/ibm_zos_core/issues/1258).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps the note here can be expanded upon to include some additional details. Maybe something like:

With ZOAU version 1.3.0, if double quotes (") are used in the I(block) parameter, the module
fails with an error message containing: 'return content is NOT in json format'. This is currently a false negative response, where the I(src) is changed, but an error is reported anyhow. Follow up on the issue tracked L(here,#1258).

Feel free to re-reword what I've got, my point is just to add more info about the behavior for the user.

seealso:
- module: zos_data_set
'''
Expand Down
3 changes: 3 additions & 0 deletions plugins/modules/zos_lineinfile.py
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,9 @@
needs to be encoded, it should be cataloged first.
- For supported character sets used to encode data, refer to the
L(documentation,https://ibm.github.io/z_ansible_collections_doc/ibm_zos_core/docs/source/resources/character_set.html).
- When working with ZOAU version 1.3.0, the module fails when C(src) is a data set and
either C(insertafter) or C(insertbefore) is set in addition to C(regexp).
Follow up on the L(issue in the collection's repository,https://github.com/ansible-collections/ibm_zos_core/issues/1244).
"""

EXAMPLES = r"""
Expand Down
Loading