[bugfix][1678]Add validation for maker begin end

changelogs/fragments/1684-Add_validation_for_marker_begin_end.yml

@@ -0,0 +1,4 @@
+bugfixes:
+  - zos_blockinfile - User could set same values for marker begin and end generate issue on ZOAU python API.
+    Change now catch the error and throw to the user a message with the problem.
+    (https://github.com/ansible-collections/ibm_zos_core/pull/1684).

plugins/modules/zos_blockinfile.py

@@ -96,13 +96,15 @@
   marker_begin:
     description:
     - This will be inserted at C({mark}) in the opening ansible block marker.
+    - Required unique value different from marker_end
     required: false
     type: str
     default: BEGIN
   marker_end:
     required: false
     description:
     - This will be inserted at C({mark}) in the closing ansible block marker.
+    - Required unique value different from marker_begin
     type: str
     default: END
   backup:
@@ -759,7 +761,8 @@ def main():
         marker_begin = 'BEGIN'
     if not marker_end:
         marker_end = 'END'
-
+    if marker_begin == marker_end:
+        module.fail_json(msg='marker begin and fail required unique values')
     marker = "{0}\\n{1}\\n{2}".format(marker_begin, marker_end, marker)
     block = transformBlock(block, ' ', indentation)
     # analysis the file type

tests/functional/modules/test_zos_blockinfile_func.py

@@ -81,6 +81,24 @@
 PYTHON_HOME=/usr/lpp/izoda/v110/anaconda
 export ZOAU_ROOT"""
 
+TEST_CONTENT_NOT_DEFAULTMARKER = """if [ -z STEPLIB ] && tty -s;
+then
+    export STEPLIB=none
+    exec -a 0 SHELL
+fi
+TZ=PST8PDT
+export TZ
+export MAIL
+umask 022
+*HELLO USER MANAGED BLOCK
+ZOAU_ROOT=/usr/lpp/zoautil/v100
+ZOAUTIL_DIR=/usr/lpp/zoautil/v100
+*BYE USER MANAGED BLOCK
+ZOAU_ROOT=/usr/lpp/zoautil/v100
+PKG_CONFIG_PATH=/usr/lpp/izoda/v110/anaconda/lib/pkgconfig
+PYTHON_HOME=/usr/lpp/izoda/v110/anaconda
+export ZOAU_ROOT"""
+
 TEST_CONTENT_CUSTOMMARKER = """if [ -z STEPLIB ] && tty -s;
 then
     export STEPLIB=none
@@ -696,6 +714,30 @@ def test_uss_block_absent_defaultmarker(ansible_zos_module):
         remove_uss_environment(ansible_zos_module, full_path)
 
 
+@pytest.mark.uss
+def test_uss_block_absent_not_defaultmarker(ansible_zos_module):
+    hosts = ansible_zos_module
+    params = {
+        "state":"absent",
+        "marker_begin":"HELLO",
+        "marker_end":"BYE",
+        "marker":"*{mark} USER MANAGED BLOCK"
+    }
+    full_path = get_random_file_name(dir=TMP_DIRECTORY)
+    content = TEST_CONTENT_NOT_DEFAULTMARKER
+    try:
+        set_uss_environment(ansible_zos_module, content, full_path)
+        params["path"] = full_path
+        results = hosts.all.zos_blockinfile(**params)
+        for result in results.contacted.values():
+            assert result.get("changed") is True
+        results = hosts.all.shell(cmd="cat {0}".format(params["path"]))
+        for result in results.contacted.values():
+            assert result.get("stdout") == EXPECTED_ABSENT
+    finally:
+        remove_uss_environment(ansible_zos_module, full_path)
+
+
 @pytest.mark.uss
 def test_uss_block_absent_custommarker(ansible_zos_module):
     hosts = ansible_zos_module