[Bugfix] [module_utils] [multiple modules] tmp_hlq use in utils whenever mvscmd gets called

[rexemin]

SUMMARY

Fixes #912.

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

• module_utils/data_set.py

ADDITIONAL INFORMATION

Includes a lot of small changes just to pass the tmp_hlq used by modules all the way down to either DataSet or DataSetUtils where it can be used every time we make a call to mvscmd.

[richp405]

Nice and thorough.

[ketankelkar]

really good work here, i liked your core fix to leveraging the -Q CLI option for specifying temporary high level qualifiers while we wait for the python api to become availble.

Change requests are:

• a note on the focus of the changelog
• a question about potentially overlooked function calls in the data set module

[ketankelkar]

how come the rest of these ensure_* methods don't get the tmphlq passed in? I noticed for example for ensure_absent, you added a default value of tmphlq=None in the function signature, but what if the user wants to define one, how does that value make it to the function call?

[rexemin]

Are you only referring to the calls in zos_data_set or also to the functions in the data_set.py util?

The calls in zos_data_set only have tmp_hlq when they deal with common datasets, the calls that check members or GDGs don't end up using mvscmd and thus don't include the HLQ. For the specific call to data_set.ensure_absent, I included the HLQ at first, but then that caused errors while testing, so I removed it.

[ketankelkar]

I was referring to:

• ensure_present
• ensure_absent
• ensure_cataloged <-- you've got this one covered
• ensure_uncataloged <-- you've got this one covered

For ensure_absent, it calls attempt_catalog_if_necessary_and_delete which calls data_set_cataloged which calls mvscmd.

For ensure_present, it calls attempt_catalog_if_necessary which calls data_set_cataloged which calls mvscmd.

To me, it seems like both ensure_present and ensure_absent should pass thetmphlq all the way down the chain, otherwise, the module option would still be ignored for certain operations.
Any chance that the errors you got were because the chain of calls wasn't completely updated?

[rexemin]

I'm not sure what other updates I made to the code, but now the calls don't end up with errors.

[ketankelkar]

to me, it seems like ensure_present and ensure_absent in the data set module needs to accomodate tmphlq

See my reply to the comment above (link)

[ketankelkar]

LGTM - thanks for making the requested changes!

[rexemin]

Jenkins results:

---

---

---

[rexemin]

And the rest of the modules affected by the change:

---

---

---

---

---