[Bugfix][1856][zos_mount]Fails_using_persistat_option #1871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreMarcel99
changed the title
AndreMarcel99
changed the title
…ataset_with_zFS_mount
…ataset_with_zFS_mount
AndreMarcel99
requested review from
rexemin,
ketankelkar,
fernandofloresg,
richp405 and
ddimatos
fernandofloresg
requested changes
Jan 21, 2025
Co-authored-by: Fernando Flores <[email protected]>
| content = fh.read().splitlines() | ||
| datasets.delete(dataset=data_store) | ||
| datasets.copy(source=bk_ds, target=data_store) | ||
| datasets.delete(dataset=bk_ds) |
There was a problem hiding this comment.
If something goes wrong while we are writing into the backup we should always delete the backup
|
|
|
fernandofloresg
requested changes
Jan 22, 2025
| dest = get_tmp_ds_name() | ||
| dest_path = dest + "(AUTO1)" | ||
|
|
||
| hosts.all.zos_data_set( |
There was a problem hiding this comment.
Could you use zoau dtouch instead for creating this? We want to reduce on test dependency in ourselves plus is going to be more performant with the same result.
| ) | ||
| hosts.all.file(path=tmp_file_filename, state="absent") | ||
| hosts.all.file(path="/pythonx/", state="absent") | ||
| hosts.all.zos_data_set( |
There was a problem hiding this comment.
same for this one, is better to use drm in the test cases.
| @@ -255,6 +264,75 @@ def test_basic_mount_with_bpx_nocomment_nobackup(ansible_zos_module, volumes_on_ | |||
| record_length=80, | |||
| ) | |||
|
|
|||
| def test_basic_mount_with_bpx_no_utf_8_characters_(ansible_zos_module, volumes_on_systems): | |||
There was a problem hiding this comment.
It does not look like the test case is actually testing non UTF-8 characters, I tested building what we currently have in dev branch and then executed this test using :
./ac --ac-test --host ec33012a --python 3.11 --zoau 1.3.4 --file tests/functional/modules/test_zos_mount_func.py --debug --verbose vvv --test test_basic_mount_with_bpx_no_utf_8_characters_…ataset_with_zFS_mount
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Remove previous call to write manually text to the persistent dataset, now add validations using blockinfile and copy for easier validations.
Fixes #1856
ISSUE TYPE
COMPONENT NAME
Remove previous function to remove text by checking line by line, the new function use blockinfile