[Enhancement][1745][zos_script]Gracefully_fail_when_remote_src_does_not_exist

[AndreMarcel99]

SUMMARY

Add verification to remote_src and file does not exist with error message

Fixes #1745

ISSUE TYPE

• Enhancement Pull Request

ADDITIONAL INFORMATION

Here is the new error message

{'failed': True, 'changed': False, 'msg': 'File /tmp/zos_script_test_script does not exists on the system, skipping script', 'invocation': {'module_args': {'chdir': None, 'cmd': '/tmp/zos_script_test_script', 'creates': None, 'executable': None, 'remote_src': True, 'removes': None, 'use_template': False, 'template_parameters': None}}, '_ansible_no_log': None}

[fernandofloresg]

Looks like if statement logic needs a revamp.

[fernandofloresg]

This is not taking into account when the cmd_str contains args. Modified the following test case

def test_rexx_script_with_args(ansible_zos_module):
    hosts = ansible_zos_module

    try:
        rexx_script = REXX_SCRIPT_ARGS
        script_path = create_local_file(rexx_script, 'rexx')

        first_arg = 'one'
        second_arg = 'two'
        args = f'FIRST={first_arg} SECOND={second_arg}'
        script_path = '/test.rexx'
        cmd = f"{script_path} '{args}'"

        hosts.all.shell(cmd="echo '{0}' '{1}' ".format(REXX_SCRIPT_ARGS, script_path))
        zos_script_result = hosts.all.zos_script(
            cmd=cmd,
            remote_src=True,
        )

        for result in zos_script_result.contacted.values():
            print(result)
            assert result.get('changed') is True
            assert result.get('failed', False) is False
            assert result.get('rc') == 0
            assert first_arg in result.get('stdout', '')
            assert second_arg in result.get('stdout', '')
            # Making sure the action plugin passed every argument to the module.
            assert args in result.get('invocation').get('module_args').get('cmd')
            assert args in result.get('remote_cmd')
            assert result.get('stderr', '') == ''
    finally:
        if os.path.exists(script_path):
            os.remove(script_path)

and fails with error message:

 {'failed': True, 'changed': False, 'msg': "File /test.rexx 'FIRST=one SECOND=two' does not exists on the system, skipping script", 'invocation': {'module_args': {'chdir': None, 'cmd': "/test.rexx 'FIRST=one SECOND=two'", 'creates': None, 'executable': None, 'remote_src': True, 'removes': None, 'use_template': False, 'template_parameters': None}}, '_ansible_no_log': False}

This was not discovered in functional tests because there is no functional tests that test scripts with args when remote_src is true.

[AndreMarcel99]

Good catch

[fernandofloresg]

Just above comment please test with args too.

[AndreMarcel99]

[rexemin]

A tiny typo: exist instead of exists

[fernandofloresg]

Great! You even added a test case for testing a script with args and remote.